Update blocked ESM only packages (execa, process-exists) #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
use-esm-modules
branch
from
7c34b35 to
3060094
Compare
mattseddon
commented
May 10, 2023
extension/src/process/execution.ts
Outdated
|
|
||
| let execa: EsmExeca | ||
| let doesProcessExist: EsmProcessExists | ||
| const importEsmModules = async () => { |
There was a problem hiding this comment.
[F] The reason that we cannot simply await import('execa') before we call it is that whenever we create a process the function has to be sync. If a Promise<Process> is returned then we cannot attach anything to it. We can only await the stdout.
There was a problem hiding this comment.
this is still relevant
mattseddon
force-pushed
the
use-esm-modules
branch
2 times, most recently
from
fd91f06 to
1fdc13f
Compare
mattseddon
force-pushed
the
use-esm-modules
branch
from
1fdc13f to
d44731f
Compare
mattseddon
force-pushed
the
use-esm-modules
branch
from
5d3190b to
b610330
Compare
mattseddon
force-pushed
the
use-esm-modules
branch
from
b610330 to
3094ba8
Compare
sroy3
approved these changes
May 11, 2023
|
Code Climate has analyzed commit 85a9c91 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9%. View more on Code Climate. |
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, I've wanted to update
execaandprocess-existsbut have been unable to because they are ESM only packages. Importing these modules is now possible (after discovering"moduleResolution": "node16"by chance). This PR upgrade the aforementioned packages and integrates the way we now need to import them with the rest of code base.Please LMK if you have any questions 🙏🏻.