Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent queued experiment from being selected as most recent #3846

Merged
merged 2 commits into from
May 9, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 9, 2023

Fixes the bug shown at the end of this demo:

Screen.Recording.2023-05-09.at.2.42.17.pm.mov

@mattseddon mattseddon added the bug Something isn't working label May 9, 2023
@mattseddon mattseddon self-assigned this May 9, 2023
@mattseddon mattseddon marked this pull request as ready for review May 9, 2023 04:50
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 9, 2023 04:50
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon enabled auto-merge (squash) May 9, 2023 19:26
@codeclimate
Copy link

codeclimate bot commented May 9, 2023

Code Climate has analyzed commit b95c74f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.8% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 9da00b1 into main May 9, 2023
@mattseddon mattseddon deleted the prevent-queued branch May 9, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants