Prevent queued experiment from being selected as most recent

iterative · May 9, 2023 · 8bcaa89 · 8bcaa89
1 parent 3eb2bf7
commit 8bcaa89
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/extension/src/experiments/model/status/collect.test.ts b/extension/src/experiments/model/status/collect.test.ts
@@ -356,11 +356,16 @@ describe('collectFinishedRunningExperiments', () => {
     expect(finishedRunning).toStrictEqual({})
   })
 
-  it('should return the most recently created and unseen (without a status) experiment if there is no longer an experiment running in the workspace', () => {
+  it('should return the most recently created and unseen and unqueued (without a status) experiment if there is no longer an experiment running in the workspace', () => {
     const latestCreatedId = 'exp-123'
     const finishedRunning = collectFinishedRunningExperiments(
       {},
       [
+        {
+          Created: '2023-12-01T10:48:24',
+          id: 'exp-queued',
+          status: ExperimentStatus.QUEUED
+        },
         { Created: '2022-12-02T10:48:24', id: 'exp-456' },
         { Created: '2022-10-02T07:48:24', id: 'exp-789' },
         { Created: '2022-12-02T07:48:25', id: latestCreatedId },

diff --git a/extension/src/experiments/model/status/collect.ts b/extension/src/experiments/model/status/collect.ts
@@ -293,7 +293,9 @@ const getMostRecentExperiment = (
   coloredStatus: ColoredStatus
 ): Experiment | undefined =>
   experiments
-    .filter(({ id }) => coloredStatus[id] === undefined)
+    .filter(
+      ({ id, status }) => coloredStatus[id] === undefined && !isQueued(status)
+    )
     .sort(({ Created: aCreated }, { Created: bCreated }) => {
       if (!aCreated) {
         return 1