Group table styles #3667
Merged
Group table styles #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Apr 12, 2023
| @@ -683,10 +744,6 @@ td { | |||
| font-size: 0.65rem; | |||
| } | |||
|
|
|||
| .staticColumn { | |||
There was a problem hiding this comment.
Class isn't being used anywhere.
| left: auto; | ||
| background-color: transparent; | ||
| } | ||
| .bodyRow { |
There was a problem hiding this comment.
The tr {} held styles that only affect body rows (doesn't affect the head rows at all). I moved them outside of it and into the bodyRow selector. The body row styles can be cleaned up further but I'll save that for another chain pr that focused on cleaning up body styles.
mattseddon
approved these changes
Apr 13, 2023
sroy3
approved these changes
Apr 13, 2023
This was referenced Apr 13, 2023
|
Code Climate has analyzed commit 63f0b22 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.8% (0.0% change). View more on Code Climate. |
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/4
main<= this <= #3674 <= #3681 <= #3707Note: I'm not planning to merge this until all WIP prs are done and approved!
Part of #3597