Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Experiments Table SCSS #3597

Closed
mattseddon opened this issue Mar 31, 2023 · 1 comment · Fixed by #3736
Closed

Clean up Experiments Table SCSS #3597

mattseddon opened this issue Mar 31, 2023 · 1 comment · Fixed by #3736
Assignees
Labels
A: experiments Area: experiments table webview and everything related 🏠 housekeeping

Comments

@mattseddon
Copy link
Member

As discussed in the retro, when working on #3591 I noticed that the scss associated with the experiments table has organically grown unruly.

We should take a few hours to clean up webview/src/experiments/components/table/styles.module.scss.

We should also spend some investigating linters. E.g

@mattseddon mattseddon added 🏠 housekeeping A: experiments Area: experiments table webview and everything related labels Mar 31, 2023
@mattseddon mattseddon changed the title Clean up Experiments Table SCSS. Clean up Experiments Table SCSS Mar 31, 2023
@julieg18 julieg18 self-assigned this Apr 4, 2023
This was referenced Apr 11, 2023
This was referenced Apr 12, 2023
@sroy3
Copy link
Contributor

sroy3 commented Apr 17, 2023

I was thinking about this and I think that the main problem is that we are using CSS modules, but our stylesheets aren't modular enough. We basically have one big module per webview. If we were to create a stylesheet (module) per component or per component group (table head, table body...). That way, we can see much more easily what styles are used / unused, overwritten, and know exactly where to find them. @julieg18 I think you already did a great job in cleaning up everything and especially grouping stuff. If we decide to move things to their own module, that'll streamline thing a lot. I guess we can talk about this in the next retro, or just start slowly moving things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related 🏠 housekeeping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants