-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up table styles #3664
Clean up table styles #3664
Conversation
* move classes out of .experiments * delete unused classes/selectors
@@ -237,404 +233,389 @@ $bullet-size: calc(var(--design-unit) * 4px); | |||
height: 100%; | |||
display: flex; | |||
flex-flow: column nowrap; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the styles, the main issues seem to be the fact that there is a lot of nesting and classes/elements are selected at different parts throughout the file, making it difficult to actually see what styles are being applied to what.
I figured the first step is moving everything out of .experiments {}
then start grouping the classes better.
I think the changes in storybooks are caused by past changes not being accepted in a different pr 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first step. That'll definitely make next changes easier.
Code Climate has analyzed commit 1da4779 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (0.0% change). View more on Code Climate. |
.experiments
summary
,.hidden
,.depthSpacer
,.webviewWrapper
,.arrowLeft
,.arrowRight
)Start to #3597