Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up table styles #3664

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Clean up table styles #3664

merged 3 commits into from
Apr 11, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Apr 11, 2023

  • move everything out of .experiments
  • delete unused classes/selectors (summary, .hidden, .depthSpacer, .webviewWrapper, .arrowLeft, .arrowRight)

Start to #3597

* move classes out of .experiments
* delete unused classes/selectors
@@ -237,404 +233,389 @@ $bullet-size: calc(var(--design-unit) * 4px);
height: 100%;
display: flex;
flex-flow: column nowrap;
}
Copy link
Contributor Author

@julieg18 julieg18 Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the styles, the main issues seem to be the fact that there is a lot of nesting and classes/elements are selected at different parts throughout the file, making it difficult to actually see what styles are being applied to what.

I figured the first step is moving everything out of .experiments {} then start grouping the classes better.

@julieg18
Copy link
Contributor Author

I think the changes in storybooks are caused by past changes not being accepted in a different pr 😅

@julieg18 julieg18 marked this pull request as ready for review April 11, 2023 00:58
Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step. That'll definitely make next changes easier.

@codeclimate
Copy link

codeclimate bot commented Apr 11, 2023

Code Climate has analyzed commit 1da4779 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.9% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 239a1fb into main Apr 11, 2023
@julieg18 julieg18 deleted the clean-up-table-scss branch April 11, 2023 13:37
@julieg18 julieg18 mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants