Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch add Studio access token to update when Studio is connected #3400

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 6, 2023

2/2 main <- #3399 <- this

Related to #3077

This PR switches dvc.addStudioAccessToken to dvc.updateStudioAccessToken when Studio is connected.

As per this thread.

Demo

Screen.Recording.2023-03-06.at.1.39.51.pm.mov

@mattseddon mattseddon added the product PR that affects product label Mar 6, 2023
@mattseddon mattseddon self-assigned this Mar 6, 2023
@mattseddon mattseddon changed the base branch from main to add-show-options March 6, 2023 02:39
@mattseddon mattseddon marked this pull request as ready for review March 6, 2023 02:41
@mattseddon mattseddon requested a review from shcheklein March 6, 2023 02:41
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from add-show-options to main March 6, 2023 18:07
@mattseddon mattseddon force-pushed the fix-update-studio-access-token branch from 855c278 to 7ae5600 Compare March 6, 2023 18:08
@mattseddon mattseddon enabled auto-merge (squash) March 6, 2023 18:08
@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 7ae5600 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.8%.

View more on Code Climate.

@mattseddon mattseddon merged commit 87ffcf8 into main Mar 6, 2023
@mattseddon mattseddon deleted the fix-update-studio-access-token branch March 6, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants