Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Open Studio Settings in the command palette #3399

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Expose Open Studio Settings in the command palette #3399

merged 2 commits into from
Mar 6, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 6, 2023 •
edited
Loading

1/2 main <- this <- #3400

Related to #3077

User's will now be able to access the Studio settings through the command palette.

Demo

Screen.Recording.2023-03-06.at.1.12.31.pm.mov

@mattseddon mattseddon added the product PR that affects product label Mar 6, 2023
@mattseddon mattseddon self-assigned this Mar 6, 2023
@mattseddon mattseddon marked this pull request as ready for review March 6, 2023 02:26
@mattseddon mattseddon requested a review from shcheklein March 6, 2023 02:26
@shcheklein
Copy link
Member

Good, we can go with this as a next step. I think we need to figure out something though with the number of different screens and buttons- we need to consolidate them. Btw, will the button stay "Connect Studio" initially, when there is no token yet?

@mattseddon
Copy link
Member Author

Good, we can go with this as a next step. I think we need to figure out something though with the number of different screens and buttons- we need to consolidate them. Btw, will the button stay "Connect Studio" initially, when there is no token yet?

It is under the Studio tree so it says "Connect":

Screen.Recording.2023-03-06.at.1.38.01.pm.mov

@mattseddon mattseddon mentioned this pull request Mar 6, 2023
Merged
julieg18
julieg18 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon enabled auto-merge (squash) March 6, 2023 17:56
@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 59a5605 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.8%.

View more on Code Climate.

@mattseddon mattseddon merged commit e10ca30 into main Mar 6, 2023
@mattseddon mattseddon deleted the add-show-options branch March 6, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julieg18 julieg18 julieg18 approved these changes

@sroy3 sroy3 sroy3 approved these changes

@shcheklein shcheklein Awaiting requested review from shcheklein shcheklein is a code owner

Assignees

@mattseddon mattseddon

Labels
product PR that affects product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattseddon @shcheklein @sroy3 @julieg18