Consolidate use of input box validation #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jan 4, 2023
| window.showInputBox({ | ||
| title, | ||
| value | ||
| }) | ||
|
|
||
| export const getValidInput = ( | ||
| const getValidInput = ( |
There was a problem hiding this comment.
[F] If we are concerned then I can try to find ~1 day to get these validators under test.
julieg18
approved these changes
Jan 4, 2023
| if (!includeZero) { | ||
| return number > 0 | ||
| } | ||
| return number >= 0 |
There was a problem hiding this comment.
Not sure if it looks better but you could turn these four lines into one:
return includeZero ? number >= 0 : number > 0
extension/src/vscode/inputBox.ts
Outdated
| window.showInputBox({ | ||
| prompt: options?.prompt, | ||
| title, | ||
| validateInput, | ||
| value: options?.value | ||
| }) | ||
|
|
||
| const isValid = ( |
There was a problem hiding this comment.
Should this function be isValidNumber since the function is focused on checking numbers?
sroy3
approved these changes
Jan 4, 2023
mattseddon
force-pushed
the
use-integer-validator
branch
from
44e4f26 to
cdd6a02
Compare
|
Code Climate has analyzed commit c5f405a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 45.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #3048 <- thisThis PR consolidates our use of validation functions with respect to the VS Code
InputBox.Demo
Screen.Recording.2023-01-04.at.4.21.38.pm.mov