-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the user to specify a number of concurrent jobs when starting the experiments queue #3048
Conversation
c3c5490
to
ad5ee4b
Compare
@@ -19,8 +19,7 @@ import { Disposable } from '../../class/dispose' | |||
|
|||
export const autoRegisteredCommands = { | |||
EXPERIMENT_RESET_AND_RUN: 'runExperimentReset', | |||
EXPERIMENT_RUN: 'runExperiment', | |||
EXPERIMENT_RUN_QUEUED: 'runExperimentQueue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] I've moved this from here into the executor (no output is returned to the runner's terminal anymore anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The legacy behaviour was for all of the logs to be fed into the terminal's output.
undefined | ||
) | ||
|
||
const dDosNumberOfJobs = '10000' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] May or may not have run this by accident whilst testing the input box...
if (!input) { | ||
return | ||
} | ||
return Number.parseInt(input).toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] I'll follow up to bring setMaxTableHeadDepth
onto this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Code Climate has analyzed commit 832a176 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 80.6% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (0.0% change). View more on Code Climate. |
1/2
main
<- this <- #3049Relates to #3042
This PR puts an input box in front of starting the queue. The user now has to enter the number of workers that they want to run the queue with.
Demo
Screen.Recording.2023-01-04.at.3.10.32.pm.mov