Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the user to specify a number of concurrent jobs when starting the experiments queue #3048

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jan 4, 2023

1/2 main <- this <- #3049

Relates to #3042

This PR puts an input box in front of starting the queue. The user now has to enter the number of workers that they want to run the queue with.

Demo

Screen.Recording.2023-01-04.at.3.10.32.pm.mov

@mattseddon mattseddon added the product PR that affects product label Jan 4, 2023
@mattseddon mattseddon self-assigned this Jan 4, 2023
@@ -19,8 +19,7 @@ import { Disposable } from '../../class/dispose'

export const autoRegisteredCommands = {
EXPERIMENT_RESET_AND_RUN: 'runExperimentReset',
EXPERIMENT_RUN: 'runExperiment',
EXPERIMENT_RUN_QUEUED: 'runExperimentQueue'
Copy link
Member Author

@mattseddon mattseddon Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] I've moved this from here into the executor (no output is returned to the runner's terminal anymore anyway).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy behaviour was for all of the logs to be fed into the terminal's output.

undefined
)

const dDosNumberOfJobs = '10000'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] May or may not have run this by accident whilst testing the input box...

if (!input) {
return
}
return Number.parseInt(input).toString()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] I'll follow up to bring setMaxTableHeadDepth onto this.

@mattseddon mattseddon marked this pull request as ready for review January 4, 2023 04:49
@mattseddon mattseddon requested a review from shcheklein January 4, 2023 05:33
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2023

Code Climate has analyzed commit 832a176 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

The test coverage on the diff in this pull request is 80.6% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.4% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 1ece29b into main Jan 4, 2023
@mattseddon mattseddon deleted the queue-quick-pick branch January 4, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants