2/3 - Add new decorations #265
Conversation
| } | ||
|
|
||
| private static DecorationNotInCache: FileDecoration = { | ||
| badge: 'NC', |
There was a problem hiding this comment.
[Q] No idea what to match this one to.
There was a problem hiding this comment.
I think the ideal color here depends on what action a user is supposed to take on "Not in Cache" files.
If it's best practice to add these files cache ASAP and doing so is easy, we can use colors.conflict to signify that this file should be added to cache.
If "Not in Cache" files are normal, we should pick a more benign Git color to match: conceptually it seems closest to "Modified", but that's just a hunch. If the solution to DVC "Not in Cache" is similar to DVC "modified", then I think using colors.modified for both decorations and depending on badge/tooltip to distinguish the two would be a fine way to go about it.
This is definitely something that'll be good to bring up at a meeting.
Addresses several of the points in #207.
Adds decoration to each of the different status types.