Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: Match Git extension decoration for paths tracked by DVC #207

Closed
7 tasks done
mattseddon opened this issue Mar 25, 2021 · 1 comment
Closed
7 tasks done

Story: Match Git extension decoration for paths tracked by DVC #207

mattseddon opened this issue Mar 25, 2021 · 1 comment
Assignees
Labels
A: extension Area: core extension research story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc

Comments

@mattseddon
Copy link
Member

mattseddon commented Mar 25, 2021

This issue is a follow up from this comment on #186:

In the Explorer we want to do our best to copy the decoration feature that the Git extension provides. This will mean that we want to:

  • Un-highlight (currently greyed out) paths that are Git ignored if they are tracked by DVC (see Spike decoration provider #206).
  • Highlight and add a M to paths that are tracked by DVC which have been modified since the last commit.
  • Highlight and add a U to paths that are neither tracked by Git nor DVC.
  • Highlight and add a D to paths that have been deleted.
  • Re-grey out paths that become untracked (dvc remove) by DVC.
  • Do not squash VS Code's problem matcher which will highlight files in red when a problem is found in the file.
  • Improve efficiency of extension fetching list of tracked paths (currently initial load is too slow).

We can tie into the custom colors that are used by the Git extension (see list of gitDecoration settings in linked comment).
This story will be updated as we get further into the process.

@mattseddon mattseddon added story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc research vscode A: extension Area: core extension labels Mar 25, 2021
@mattseddon mattseddon changed the title Story: Match Git extension decoration for files tracked by DVC Story: Match Git extension decoration for paths tracked by DVC Mar 25, 2021
@shcheklein shcheklein removed the vscode label Apr 5, 2021
@mattseddon mattseddon self-assigned this Apr 13, 2021
@mattseddon
Copy link
Member Author

replaced by #207, #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: extension Area: core extension research story Product feature aka epic. Discussion, progress, checkboxes for implementation, etc
Projects
None yet
Development

No branches or pull requests

2 participants