Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments Table Headers - Remove context menu's click trigger #2625

Merged
merged 5 commits into from
Oct 19, 2022

Conversation

wolmir
Copy link
Contributor

@wolmir wolmir commented Oct 18, 2022

Part of #2256

This PR will remove the left-click trigger from the table header's context menu.

It also moves the table header components to their own subfolder.

@wolmir wolmir added enhancement New feature or request A: experiments Area: experiments table webview and everything related labels Oct 18, 2022
@wolmir wolmir self-assigned this Oct 18, 2022
@wolmir wolmir force-pushed the context-menu-remove-click-trigger branch from 93b75b0 to 0f0e61d Compare October 19, 2022 12:53
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit 2c74455 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@wolmir wolmir merged commit 5a382de into main Oct 19, 2022
@wolmir wolmir deleted the context-menu-remove-click-trigger branch October 19, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants