Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table header improvements #2256

Closed
10 of 11 tasks
shcheklein opened this issue Aug 24, 2022 · 6 comments · Fixed by #5210
Closed
10 of 11 tasks

Table header improvements #2256

shcheklein opened this issue Aug 24, 2022 · 6 comments · Fixed by #5210
Assignees
Labels
A: experiments Area: experiments table webview and everything related bug Something isn't working enhancement New feature or request 🔍 review A placeholder issue to review certain part of the product or story

Comments

@shcheklein
Copy link
Member

shcheklein commented Aug 24, 2022

Screen Shot 2022-08-24 at 1 41 17 PM

  • Add hide columns / section there (and in every other menu) (Add missing "Hide Column" option to the other headers #2593)
  • ESC must work to close context menu
  • The context menu in the header cells should appear only on the right click. Currently also works with the left click (Disable Left Click trigger for Context Menu #2603)
  • Context menu "Change height" should be available everywhere. Now it doesn't show on metric file column.
  • Add filter by to context menus
  • Add hover styles to header cells
  • The sort arrow in the header cell does need to have BG on hover but needs to have a cursor (pointer)
  • Click on the Sort arrow - the context menu appears - if you hover on the arrow again the tooltip will be shown on top of the context menu. Do not show a tooltip when the menu is opened
  • The D&D cursor appears when the header block has hovered. Blocks like "Create" have no active space on top. Let's make sure that all the space of the block can be used to D&D
  • Context menu doesn't show on an empty stub on top of a column (e.g. train.py dependecy).
@shcheklein shcheklein added bug Something isn't working 🔍 review A placeholder issue to review certain part of the product or story A: experiments Area: experiments table webview and everything related enhancement New feature or request labels Aug 24, 2022
@maxagin
Copy link
Contributor

maxagin commented Aug 25, 2022

There must be a way to copy file names / section names. Full name and partial name.

Please see: Text selection in the table's header and body cells #2260

@maxagin
Copy link
Contributor

maxagin commented Sep 7, 2022

There must be a way to copy file names / section names. Full name and partial name.

It will be handled here #2260

@maxagin
Copy link
Contributor

maxagin commented Sep 7, 2022

Some of the todo items were moved to #2241

@maxagin
Copy link
Contributor

maxagin commented Sep 7, 2022

  • The context menu in the header cells should appear only on the right click. Currently also works with the left click

The description was updated. The new task was included.

@maxagin
Copy link
Contributor

maxagin commented Oct 7, 2022

Can “Open to the Side” params, but not training_metrics. Why? If I am not mistaken this should work for any file that can be opened on the side.

@wolmir
Copy link
Contributor

wolmir commented Oct 13, 2022

Add hide columns / section there (and in every other menu)

This one is deceptively tricky, I implemented a solution, and now I'm adding/fixing some tests. Still, it will need some manual testing during review to catch side-effects.

Note: The PR is open for this, I'll proceed with the other items in separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related bug Something isn't working enhancement New feature or request 🔍 review A placeholder issue to review certain part of the product or story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants