-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text selection in the table's header and body cells #2260
Comments
@shcheklein, in the case of "There must be" we could follow the same idea as introduced for the Body cells. But this is only if there is a good reason for it. Can you please explain why would user need to copy textual information from the header. Thanks |
People always want to copy things in all places in the interface. To put into a text, to send a name in chat, to put into a report, to put into a browser, etc, etc. It's a general rule - if something is not easy to copy most likely it's a bug.
I don't like this option since we are introducing an extra state to it. Kinda an active cell. It is complicated. Also, let's first fix things that are broken (headers), then do improvements ... also duplicate of the copy button discussion? |
Let's split this please and deduplicate with other things. |
People are familiar with what they use on daily basis. Proving otherwise is very difficult.
Just in case you have not seen it:
👉 However, as I have mentioned already we can follow the same idea as introduced for the Body cells (see the description). Please let me know if this is the case.
Just in case you have not seen it:
👉 I would suggest reviewing the proposal again, please. Thank you @shcheklein ! |
You can click an copy
So, in all cases (except Excel that is a clear edge case) - it's possible to copy information.
yep, I don't the recent idea for body cell - we keep complicating and complicating things to my mind
Same as above - each service has its own reasons. We need to understand why and what is done, fundamentals, strive for simplicity. |
And on more thing - in our case header is way way more critical vs all the services above. In our case we have path to files or a nested option - it's super important to be able to copy the full part, relative path, just that name, etc. It's a severe UX bug for not allowing that. |
This comment was marked as outdated.
This comment was marked as outdated.
@shcheklein, the proposal was reformulated and equipped with video examples. Please let me know WDYT? Thanks |
Is it about cell values only now? (not header?) - let's rename the ticket then (we have a separate one for the header, right?) Tbh, this logic with active cells feels too complicated, including implementation, I don't see enough value in it. What problem are we going to solve with it- to remove the button or you see other reasons/motivation? |
Both header and body have the same behaviour:
All the revised products do pretty much the same (except for the Wandb, which is far from been perfect UX, IMO)
|
@shcheklein I have not got any arguments from you about this subject. Any comments? |
@maxagin it's not a priority right now, sorry. Let's get back to it when we have more progress on things that are more important at the moment. |
Table improvements proposal based on research and comparison of different products.
Header
Select text in header cells:
https://user-images.githubusercontent.com/98249521/188774816-637612a4-8aaa-4303-a5a8-398bd237043f.mov
https://user-images.githubusercontent.com/98249521/188774849-627172ba-6811-415b-a510-b5f804708cfc.mov
https://user-images.githubusercontent.com/98249521/188774857-ad6e4c78-8246-4020-9b18-3a137a74d780.mov
https://user-images.githubusercontent.com/98249521/188774864-9a43c3d2-f240-4702-a85e-11d28d075633.mov
Can select text after clicking on cell:
https://user-images.githubusercontent.com/98249521/188775875-06686533-015d-420b-ab04-3b80521c91b2.mov
https://user-images.githubusercontent.com/98249521/188775881-075c961b-1e99-4a1c-8ea1-178c39a75892.mov
https://user-images.githubusercontent.com/98249521/188775887-ef1e13e8-f9a3-4000-873c-c11cca9d8900.mov
https://user-images.githubusercontent.com/98249521/188775892-f1b9efb1-4206-47e2-9ab1-5d71a9b295fd.mov
Can select text after double click on cell:
https://user-images.githubusercontent.com/98249521/188776323-bd666d99-d738-472d-b071-f4ca255c89c2.mov
https://user-images.githubusercontent.com/98249521/188776329-06b1feef-0c10-46c0-88e7-4d960cb3e75f.mov
https://user-images.githubusercontent.com/98249521/188776340-f7f4af17-7999-47eb-a92d-b7bc709c9763.mov
https://user-images.githubusercontent.com/98249521/188776351-2539cf11-791c-4d9d-8600-9f7fd03e3335.mov
Body
Select text in body cells:
https://user-images.githubusercontent.com/98249521/188776833-67daea76-7e46-44d5-8733-fbc6891365b9.mov
https://user-images.githubusercontent.com/98249521/188776840-35997561-0f69-4994-af5c-ee6813497ce9.mov
https://user-images.githubusercontent.com/98249521/188776847-da9fd8da-78e6-4876-961f-024555804dbf.mov
https://user-images.githubusercontent.com/98249521/188776856-52b7b40b-5685-497c-b98d-d54e7be2d1c5.mov
Can select text after clicking on cell:
https://user-images.githubusercontent.com/98249521/188777512-dd287369-becb-4020-9a9f-f46898fcc00f.mov
https://user-images.githubusercontent.com/98249521/188777515-1aca6454-0337-497a-84fe-2f8d23e6a3c8.mov
https://user-images.githubusercontent.com/98249521/188777525-5cf0e7d1-c397-4a82-94ac-0c2d019db563.mov
https://user-images.githubusercontent.com/98249521/188777542-c78af7fd-2352-44fd-805a-a8023d05b308.mov
Can select text using double click on cell:
https://user-images.githubusercontent.com/98249521/188777921-feaaf91f-30d9-408b-83d2-f2bebbc6891e.mov
https://user-images.githubusercontent.com/98249521/188777925-20a1add0-f575-4596-92f3-5ba51848f2cf.mov
https://user-images.githubusercontent.com/98249521/188777931-6bd5c95c-240f-4344-8866-322491697801.mov
https://user-images.githubusercontent.com/98249521/188777936-77eda11c-8e9a-4264-8cef-f753f965c96c.mov
👉 Recommending
Please share with me your thoughts about this proposal.
The text was updated successfully, but these errors were encountered: