Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text selection in the table's header and body cells #2260

Closed
maxagin opened this issue Aug 25, 2022 · 12 comments
Closed

Text selection in the table's header and body cells #2260

maxagin opened this issue Aug 25, 2022 · 12 comments
Assignees
Labels
A: experiments Area: experiments table webview and everything related discussion

Comments

@maxagin
Copy link
Contributor

maxagin commented Aug 25, 2022

Table improvements proposal based on research and comparison of different products.

Header

Select text in header cells:

  • Airtable NO
  • Google sheets NO
  • Wandb YES (but not easy to understand)
  • Monday NO
  • VSCode YES(Experiments, Timestamp) the rest NO

https://user-images.githubusercontent.com/98249521/188774816-637612a4-8aaa-4303-a5a8-398bd237043f.mov
https://user-images.githubusercontent.com/98249521/188774849-627172ba-6811-415b-a510-b5f804708cfc.mov
https://user-images.githubusercontent.com/98249521/188774857-ad6e4c78-8246-4020-9b18-3a137a74d780.mov
https://user-images.githubusercontent.com/98249521/188774864-9a43c3d2-f240-4702-a85e-11d28d075633.mov

Can select text after clicking on cell:

  • Airtable NO
  • Google sheets NO
  • Wandb NO
  • Monday YES

https://user-images.githubusercontent.com/98249521/188775875-06686533-015d-420b-ab04-3b80521c91b2.mov
https://user-images.githubusercontent.com/98249521/188775881-075c961b-1e99-4a1c-8ea1-178c39a75892.mov
https://user-images.githubusercontent.com/98249521/188775887-ef1e13e8-f9a3-4000-873c-c11cca9d8900.mov
https://user-images.githubusercontent.com/98249521/188775892-f1b9efb1-4206-47e2-9ab1-5d71a9b295fd.mov

Can select text after double click on cell:

  • Airtable YES
  • Google sheets YES
  • Wandb NO
  • Monday YES

https://user-images.githubusercontent.com/98249521/188776323-bd666d99-d738-472d-b071-f4ca255c89c2.mov
https://user-images.githubusercontent.com/98249521/188776329-06b1feef-0c10-46c0-88e7-4d960cb3e75f.mov
https://user-images.githubusercontent.com/98249521/188776340-f7f4af17-7999-47eb-a92d-b7bc709c9763.mov
https://user-images.githubusercontent.com/98249521/188776351-2539cf11-791c-4d9d-8600-9f7fd03e3335.mov

Body

Select text in body cells:

  • Airtable NO
  • Google sheets NO
  • Wandb YES
  • Monday NO

https://user-images.githubusercontent.com/98249521/188776833-67daea76-7e46-44d5-8733-fbc6891365b9.mov
https://user-images.githubusercontent.com/98249521/188776840-35997561-0f69-4994-af5c-ee6813497ce9.mov
https://user-images.githubusercontent.com/98249521/188776847-da9fd8da-78e6-4876-961f-024555804dbf.mov
https://user-images.githubusercontent.com/98249521/188776856-52b7b40b-5685-497c-b98d-d54e7be2d1c5.mov

Can select text after clicking on cell:

  • Airtable NO
  • Google sheets NO
  • Wandb YES
  • Monday YES

https://user-images.githubusercontent.com/98249521/188777512-dd287369-becb-4020-9a9f-f46898fcc00f.mov
https://user-images.githubusercontent.com/98249521/188777515-1aca6454-0337-497a-84fe-2f8d23e6a3c8.mov
https://user-images.githubusercontent.com/98249521/188777525-5cf0e7d1-c397-4a82-94ac-0c2d019db563.mov
https://user-images.githubusercontent.com/98249521/188777542-c78af7fd-2352-44fd-805a-a8023d05b308.mov

Can select text using double click on cell:

  • Airtable YES
  • Google sheets YES
  • Wandb YES
  • Monday YES

https://user-images.githubusercontent.com/98249521/188777921-feaaf91f-30d9-408b-83d2-f2bebbc6891e.mov
https://user-images.githubusercontent.com/98249521/188777925-20a1add0-f575-4596-92f3-5ba51848f2cf.mov
https://user-images.githubusercontent.com/98249521/188777931-6bd5c95c-240f-4344-8866-322491697801.mov
https://user-images.githubusercontent.com/98249521/188777936-77eda11c-8e9a-4264-8cef-f753f965c96c.mov

👉 Recommending

  1. Remove text selection in body cells option
  2. Can select text on double click or by highlighting only after the click on the cell
  3. The cursor is the default until the cell editing option is activated with a click on it
  4. After clicking on a cell display the total value. If the value does not fit, when highlighting user can still select the entire number
  5. When the cell is clicked we need to show the editing style (border inside the cell for example)
  6. After the click on cell - hide the copy icon

Please share with me your thoughts about this proposal.

@maxagin maxagin self-assigned this Aug 25, 2022
@maxagin maxagin mentioned this issue Aug 25, 2022
11 tasks
@maxagin
Copy link
Contributor Author

maxagin commented Aug 25, 2022

There must be a way to copy file names / section names. Full name and partial name.
Table header improvements #2256

@shcheklein, in the case of "There must be" we could follow the same idea as introduced for the Body cells. But this is only if there is a good reason for it. Can you please explain why would user need to copy textual information from the header. Thanks

@shcheklein
Copy link
Member

Can you please explain why would user need to copy textual information from the header.

People always want to copy things in all places in the interface. To put into a text, to send a name in chat, to put into a report, to put into a browser, etc, etc. It's a general rule - if something is not easy to copy most likely it's a bug.

Can select text on double click or by highlighting only after the click on the cell

I don't like this option since we are introducing an extra state to it. Kinda an active cell. It is complicated. Also, let's first fix things that are broken (headers), then do improvements ... also duplicate of the copy button discussion?

@shcheklein shcheklein added the A: experiments Area: experiments table webview and everything related label Aug 25, 2022
@shcheklein
Copy link
Member

Let's split this please and deduplicate with other things.

@maxagin
Copy link
Contributor Author

maxagin commented Aug 29, 2022

People are familiar with what they use on daily basis. Proving otherwise is very difficult.


Can you please explain why would user need to copy textual information from the header?

People always want to copy things in all places in the interface. To put into a text, to send a name in chat, to put into a report, to put into a browser, etc, etc. It's a general rule - if something is not easy to copy most likely it's a bug.

Just in case you have not seen it:

Select text in header cells:
Airtable NO, Google sheets NO, Wandb NO, Monday NO, VSCode YES(Experiments, Timestamp) the rest NO

👉 However, as I have mentioned already we can follow the same idea as introduced for the Body cells (see the description). Please let me know if this is the case.


Can select text on double click or by highlighting only after the click on the cell

I don't like this option since we are introducing an extra state to it. Kinda an active cell. It is complicated.

Just in case you have not seen it:

Select text in body cells:
Airtable NO, Google sheets NO, Wandb YES, Monday NO, VSCode YES

Can select text after double click on cell:
Airtable YES, Google sheets YES, Monday YES


👉 I would suggest reviewing the proposal again, please. Thank you @shcheklein !

@shcheklein
Copy link
Member

Google sheets - it's ONE symbol

Airtable

Screen Shot 2022-08-29 at 9 51 20 AM

You can click an copy

W&B: The mitigate this:

Screen Shot 2022-08-29 at 10 16 45 AM

Monday - the do:

Screen Shot 2022-08-29 at 10 17 48 AM

So, in all cases (except Excel that is a clear edge case) - it's possible to copy information.


the same idea as introduced for the Body cells (see the description). Please let me know if this is the case.

yep, I don't the recent idea for body cell - we keep complicating and complicating things to my mind

Just in case you have not seen it:

Same as above - each service has its own reasons. We need to understand why and what is done, fundamentals, strive for simplicity.

@shcheklein
Copy link
Member

And on more thing - in our case header is way way more critical vs all the services above. In our case we have path to files or a nested option - it's super important to be able to copy the full part, relative path, just that name, etc. It's a severe UX bug for not allowing that.

@maxagin

This comment was marked as outdated.

@maxagin
Copy link
Contributor Author

maxagin commented Sep 7, 2022

@shcheklein, the proposal was reformulated and equipped with video examples. Please let me know WDYT? Thanks

@shcheklein
Copy link
Member

Is it about cell values only now? (not header?) - let's rename the ticket then (we have a separate one for the header, right?)

Tbh, this logic with active cells feels too complicated, including implementation, I don't see enough value in it. What problem are we going to solve with it- to remove the button or you see other reasons/motivation?

@maxagin
Copy link
Contributor Author

maxagin commented Sep 7, 2022

Is it about cell values only now? (not header?) - let's rename the ticket then (we have a separate one for the header, right?)

Both header and body have the same behaviour:

  • Click to edit cell
  • Can select and copy the total value
  • No need to have a copy button anymore

Tbh, this logic with active cells feels too complicated

All the revised products do pretty much the same (except for the Wandb, which is far from been perfect UX, IMO)

What problem are we going to solve with it

  1. clear and consistent behaviour when working with information in cells (header, body)
  2. "total value" consistent approach: short -> click -> full -> copy
  3. no movement while working with the table (copy button does not appear on hover). Better readability

@shcheklein shcheklein removed their assignment Sep 8, 2022
@maxagin
Copy link
Contributor Author

maxagin commented Sep 10, 2022

@shcheklein I have not got any arguments from you about this subject. Any comments?

@shcheklein
Copy link
Member

@maxagin it's not a priority right now, sorry. Let's get back to it when we have more progress on things that are more important at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related discussion
Projects
None yet
Development

No branches or pull requests

2 participants