Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkpoints from extension #3619

Closed
4 of 5 tasks
mattseddon opened this issue Apr 3, 2023 · 4 comments
Closed
4 of 5 tasks

Remove checkpoints from extension #3619

mattseddon opened this issue Apr 3, 2023 · 4 comments
Assignees

Comments

@mattseddon
Copy link
Member

mattseddon commented Apr 3, 2023

Follow up to #3577

Remaining items

  • Update remaining screenshots from walkthrough
  • Remove checkpoint logic from experiment collection code (extension/src/experiments/model/collect.ts)
  • Remove override revision logic from plots (replace short sha with experiment name for calling CLI).
  • Remove checkpoint type from ExperimentType enum
  • Final sweep for "patches/redundancy"
@mattseddon
Copy link
Member Author

I will start on the prerequisites for integrating iterative/dvc#9170

@mattseddon
Copy link
Member Author

One thing that I have noticed from working on #3665 is that we inconsistently display an experiment's rev/name and commit/branch's (aka baseline's) name/sha/commit message. Here are the places where we show this information:

Experiments tree

image

Experiments table

image

Plots Ribbon

image

Plots image comparison table header

image

I think we should make an update. My proposal is that in the examples above scaly-puds would always be first with adde938 de-emphasized as secondary text (i.e match the ribbon's style). I think it makes sense to do this because we have removed checkpoints and the ability to see multiple "revs" per experiment.

@dberenbaum @shcheklein WDYT?

@mattseddon
Copy link
Member Author

Realised that I missed at least one more place from the above comment.

Quick Picks

image

image

Looking at the bigger picture:

CLI

image

Studio

image

Whatever the decision I think we should standardise across all of the three products. That probably means that we want to change the Plots Ribbon for now.

@mattseddon
Copy link
Member Author

Updating screenshots will be handled in #3434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant