Remove checkpoint experiment support from extension UI #3577
Labels
A: experiments
Area: experiments table webview and everything related
A: extension
Area: core extension
A: integration
Area: DVC integration layer
Based on the discussion in iterative/dvc#9221 and the need to update
exp show --json
(iterative/dvc#9170) for #3178 & #3436. We have decided to drop checkpoints from the UI in the extension.As we are doing this at the same time as updating the parsing logic to deal with a new format of experiments data we have decided to avoid integrating the checkpoints data for now. However, (also for now) we do need still need to know whether or not there are checkpoints in the workspace's projects so that we can offer the option to resume an experiment.
UI
This change will primarily affect the experiments tree and webview. I.e these rows will be removed:
There will be flow-on effects in the rest of the extension. Below is the list of things that will need to be updated in the UI
hasCheckpoints
logic needs to be dropped for filteringFurther code changes:
package.json
As we have always treated checkpoints differently to experiments/commits all of the conditional logic in our package.json will need to be updated. E.g the
view/item/context
entry fordvc.views.experiments.applyExperiment
. Again, we should (for now) keep the ability to resume a checkpoint experiment if there are checkpoint experiments detected in any of the projects in the workspace.experiments table context menu
Conditional logic for checkpoints context menu can be dropped and the whole component can be greatly simplified.
Screen.Recording.2023-03-29.at.11.40.44.am.mov
patches/redundancy
The biggest one is
collectOverrideRevisionDetails
which is used to override plots data when there is a checkpoint experiment running in the workspace. Checkpoints should also not be passed to the code that assigns each experiment a status/color, etc.test fixtures/stories
The test fixtures will all need to be updated to match the new data coming out of iterative/dvc#9170. We will no doubt need to update multiple stories and potentially drop some.
Outside of 1, the task will consist mostly of deleting code/conditional logic branches.
Note: Sorting logic seems fine but should be revisited separately (only experiments are sorted under commits).
The text was updated successfully, but these errors were encountered: