-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plots: special chars handling for vega plots paths #6900
Conversation
Thanks @pared for addressing it quick! Is it WIP still? Also tests failing and probably we should add a test for this bug, wdyt? |
I don't have access to a Windows computer and won't have it for a few days, hence WIP. If you could confirm this fix works on windows too we could merge it faster. I will write a test. |
7421198
to
2a535c3
Compare
@shcheklein I created a simple temporary test, to make sure all the special characters get converted. We can merge this change, however, this issue is not over. To make sure we do not get more of such issues, we should introduce testing for our generated HTML. For the beginning, we should try to parse the HTML, extract |
For e2e tests, I'd suggest playwright supports all 3 platforms and 3 browsers, and has a guide for setting up CI in GHA. I'd prefer we run this on a nightly basis on a separate repository though, as we need to depend on some browsers and these tests may be flaky. |
Another reason to evict rendering out of DVC. |
I've approved, @pared . Sorry never had intention to block this (I was satisfied with the answer- In a sense I trust that you and the team could figure out the best). |
@Mergifyio rebase |
β Branch has been successfully rebased |
2a535c3
to
6742f6c
Compare
6742f6c
to
bedc4ca
Compare
Thanks for the fix. When will this be released? :) |
@JulianWgs It seems that draft release for |
@JulianWgs Regretfully we were not able to release yet, we have few major inner changes coming and the release needs to wait until we are sure everything works as intended. Meanwhile, if your use case cannot wait, I would recommend installing from master, if it's possible on your side. |
@JulianWgs |
Great news. Thanks!
|
Fixes: #6894
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
Cannot test it for now. Marking as [WIP] until I can do that or get confirmation its working on windows.