Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots show: on Windows generates broken HTML #6894

Closed
shcheklein opened this issue Oct 31, 2021 · 0 comments · Fixed by #6900
Closed

plots show: on Windows generates broken HTML #6894

shcheklein opened this issue Oct 31, 2021 · 0 comments · Fixed by #6900
Assignees
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do

Comments

@shcheklein
Copy link
Member

shcheklein commented Oct 31, 2021

Bug Report

On Windows when plot HTML is generated we don't properly generate DIV ids. Probably the problem is this replace:

div_id = f"plot_{self.filename.replace('.', '_').replace('/', '_')}"

Reproduce

it should be reproducing this to the best of my knowledge, we don't have Windows machine to easily try

Create a an empty project, add a CSV file exp\test.csv in it, add content like this:

true_labels,predicted_labels,predcited_proba
0,1,0.6459952
0,1,0.61865646
0,1,0.6695571
1,1,0.64352757
1,1,0.6563768
1,1,0.62994474

Run dvc plots show -t confusion --open .\exp\test.csv

It should be giving:

Uncaught (in promise) Error: #plot_exp	est_csv does not exist
    at [email protected]:21
    at gi ([email protected]:21)

Expected

You should see a confusion matrix

Environment information

Windows 10, conda

    conda version : 4.10.3
    conda-build version : 3.21.4
    python version : 3.8.5.final.0

Output of dvc doctor:

DVC version: 2.8.2 (conda)
---------------------------------
Platform: Python 3.9.7 on Windows-10-10.0.19043-SP0
Supports:
        gdrive (pydrive2 = 1.10.0),
        webhdfs (fsspec = 2021.10.1),
        http (aiohttp = 3.7.4.post0, aiohttp-retry = 2.4.5),
        https (aiohttp = 3.7.4.post0, aiohttp-retry = 2.4.5)

(dvc version in a project dir is broken due another bug in the dvc version itself)

@pared pared added the bug Did we break something? label Nov 1, 2021
@pared pared self-assigned this Nov 1, 2021
@pared pared added the p1-important Important, aka current backlog of things to do label Nov 1, 2021
pared added a commit to pared/dvc that referenced this issue Nov 16, 2021
efiop pushed a commit that referenced this issue Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? p1-important Important, aka current backlog of things to do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants