Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: integration #25

Open
pared opened this issue Apr 4, 2022 · 3 comments
Open

tests: integration #25

pared opened this issue Apr 4, 2022 · 3 comments
Labels
enhancement New feature or request testing

Comments

@pared
Copy link
Contributor

pared commented Apr 4, 2022

We need some end-to-end tests verifying that provided renderers gets converter to expected HTML. So far we only have those for parallel coordinates plot.
@daavoo
Copy link
Contributor

daavoo commented Apr 4, 2022

Duplicate #4 ?

@skshetry
Copy link
Member

skshetry commented Apr 4, 2022 •
edited
Loading

Also see: iterative/dvc#6900 (comment) for e2e tests running in the browser.

@pared
Copy link
Contributor Author

pared commented Apr 4, 2022

Not quite, those two are about testing HTML, so verifying that the rendering gets done and no errors are thrown on JS side. However what I mean here is that we should prepare a tests making sure that particular data points get converted into particular HTML. They might be joined with #4 but not necessarily. Our current tests resemble unit tests more than end-to-end tests.

@daavoo daavoo mentioned this issue Sep 8, 2022
Closed
@daavoo daavoo added testing enhancement New feature or request labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pared @daavoo @skshetry