Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: maker reflink, copy, default links #1841

Merged
merged 3 commits into from
Apr 15, 2019
Merged

cache: maker reflink, copy, default links #1841

merged 3 commits into from
Apr 15, 2019

Conversation

pared
Copy link
Contributor

@pared pared commented Apr 6, 2019

Fixes #1257

ghost
ghost approved these changes Apr 6, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can add a test somehow to check that reflink,copy is the default behavior? Maybe this is already, sorry if I didn't notice it.

dvc/remote/local.py Show resolved Hide resolved
tests/test_checkout.py Show resolved Hide resolved
tests/test_checkout.py Outdated Show resolved Hide resolved
@ghost ghost self-requested a review April 6, 2019 15:15
ghost
ghost previously requested changes Apr 6, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above ^

@efiop efiop changed the title cache: maker reflink, copy, default caches cache: maker reflink, copy, default links Apr 6, 2019
@pared pared force-pushed the 1257 branch 8 times, most recently from da8fb47 to 32bad56 Compare April 12, 2019 20:13
@pared pared requested a review from a user April 12, 2019 20:15
@efiop efiop mentioned this pull request Apr 15, 2019
Closed
@efiop efiop dismissed ghost ’s stale review April 15, 2019 12:33

stale

@efiop efiop merged commit bcd9373 into iterative:master Apr 15, 2019
@pared pared mentioned this pull request Apr 15, 2019
Closed
@shcheklein shcheklein mentioned this pull request Apr 24, 2019
Closed
6 tasks
@jorgeorpinel
Copy link
Contributor

Hi. Just to let you know my first commit in iterative/dvc.org#345 updates the docs to match this change. Thanks

@jorgeorpinel jorgeorpinel mentioned this pull request May 17, 2019
Merged
@pared pared deleted the 1257 branch November 12, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

link: make reflink,copy default
3 participants
@pared @jorgeorpinel @efiop