Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New cache file linking guide and related updates to existing docs #345

Merged
merged 5 commits into from
May 21, 2019
Merged

New cache file linking guide and related updates to existing docs #345

merged 5 commits into from
May 21, 2019

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented May 17, 2019 •
edited
Loading

Partially addresses #265

@jorgeorpinel jorgeorpinel requested review from shcheklein and a user May 17, 2019 01:21
@jorgeorpinel jorgeorpinel mentioned this pull request May 17, 2019
Merged
@jorgeorpinel

This comment has been minimized.

Sign in to view
shcheklein
shcheklein requested changes May 17, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a few comments. Overall it's a good start!

@jorgeorpinel jorgeorpinel changed the title WIP: New cache file linking guide New cache file linking guide and related updates to existing docs May 17, 2019
@shcheklein shcheklein temporarily deployed to dvc-org-pr-345 May 17, 2019 17:52 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 17, 2019 •
edited
Loading

OK guys I addressed the feedback but also had to push up all the other changes I have which add the new /doc/user-guide/cache-file-linking guide (See it live in review app). Hopefully it's not too many changes to review now!

P.s. I've adopted git rebase instead of merging now so my commit history in PRs looks nice 😉

@jorgeorpinel jorgeorpinel mentioned this pull request May 17, 2019
Closed
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-345 May 17, 2019 18:02 Inactive
shcheklein
shcheklein requested changes May 18, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jorgeorpinel. I put a few questions/comments to address.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-345 May 20, 2019 07:26 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-345 May 20, 2019 09:01 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-345 May 20, 2019 21:29 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-pr-345 May 20, 2019 23:02 Inactive
shcheklein
shcheklein requested changes May 21, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming the File linking section to something like Cache optimization or Large files optimization? And let's put some small intro there. Like you mentioned, it means that we can just then skip creating a separate section.

@jorgeorpinel
Updates hardlink referencs to reflink throughout the docs.
4d66a95 
Related to iterative/dvc#1841
@jorgeorpinel
Adds /doc/user-guide/cache-file-linking and...
0673133 
- Makes updates to several other docs to link to the new guide;
- Addresses 1st round of feedback in #345;
- Other misc. improvements related to this topic
@jorgeorpinel
Addesses some feedback from #345 and runs prettier on changed files.
fd23531 
Feedback addressed:
- #345 (comment)
- #345 (review)
- #345 (review)
- #345 (review)
@jorgeorpinel
Addressing feedback (round 2) from #345
4488543 
- https://github.com/iterative/dvc.org/pull/345/files/0aa0b61fd62686b0c39ed36fa05b5c2b5934a30e#pullrequestreview-239181940
- adds cache performance expandable dtails section to get-started/add-files.md
  https://github.com/iterative/dvc.org/pull/345/files/0aa0b61fd62686b0c39ed36fa05b5c2b5934a30e#pullrequestreview-239182006
- some misc. reformatting in related files
@jorgeorpinel
Expands /doc/user-guide/cache-file-linking to full optimization guide
a5f3004 
Per #345 (review)

Fixes #265
@jorgeorpinel
Copy link
Contributor Author

Ready, @shcheklein. Just a couple discussions still open above for a final decision on your part please. Thanks

@shcheklein shcheklein merged commit 0e4cfcb into iterative:master May 21, 2019
@shcheklein
Copy link
Member

Great stuff, @jorgeorpinel ! 🎉

This was referenced May 21, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop left review comments

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeorpinel @shcheklein @efiop