Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run tests with different link types #1887

Closed
pared opened this issue Apr 15, 2019 · 2 comments
Closed

test: run tests with different link types #1887

pared opened this issue Apr 15, 2019 · 2 comments
Labels
p3-nice-to-have It should be done this or next sprint testing Related to the tests and the testing infrastructure

Comments

@pared
Copy link
Contributor

pared commented Apr 15, 2019

Currently our tests for different cache types usually deal with some specific use case, and assert intended behaviour for particular cache types.
E.g.

class TestCheckoutMovedCacheDirWithSymlinks(TestDvc):

checks behavior only for "symlink" cache type.

We should consider writing consistent tests that would check appropriate behavior for each cache type. Parametrization might be a way to deal with that, but sometimes it will not be enough. (E.g. corrupting cache in hardlink and copy cache type would look differently, therefore it requires separate tests or some if's for cache type)

@efiop efiop changed the title cache: structure tests for different cache types test: run tests with different link types Apr 15, 2019
@efiop efiop added the testing Related to the tests and the testing infrastructure label Apr 15, 2019
@efiop
Copy link
Contributor

efiop commented Apr 15, 2019

Directly related to #1841

@efiop efiop added p3-nice-to-have It should be done this or next sprint and removed p4 labels Sep 25, 2019
@efiop
Copy link
Contributor

efiop commented Oct 8, 2021

stale

@efiop efiop closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-nice-to-have It should be done this or next sprint testing Related to the tests and the testing infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants