Implement Reusable Gatsby Theme #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
reviewed
Mar 30, 2022
|
This was referenced Jun 2, 2022
I can see most of those issues fit the theme repo. We can do that gradually. We can open new issues on theme repo and solving or moving these when we look into them. |
|
The base reason for failing this PR against link-checker seems to be due to huge diff (#3625 (comment)). Let's create new issue or move discussion to already existing link-checker issue(maybe #1838). And, minor issues are addressed and also we can create issue for that later as well. So, let's merge this PR unless you guys see any other issue. |
julieg18
reviewed
Jun 8, 2022
plugins/gatsby-theme-iterative-docs/src/components/Documentation/Layout/SearchForm/index.tsx
Show resolved
Hide resolved
julieg18
approved these changes
Jun 8, 2022
This was referenced Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made to try out
dvc.orgagainst the new shared website theme:@dvcorg/gatsby-theme-iterative! The parts ofdvc.orgthat are expected to be used across multiple websites are removed in this PR and imported from the theme.Things this PR does:
Removes the local plugin version of the theme and the glue code that made it
Removes components and logic that are now fully handled by the theme
Moves components and logic that shadow (replace) files in the theme into the relevant shadowing directory, "src/@dvcorg/gatsby-theme-iterative".
Updates packages (figured that making a reusable library with pinned out-of-date packages would be an issue, but possibly could have been skipped) and makes refactors to fix what that breaks
Closes
clihighlighter (updatedvc) #3589Closes Extract docs engine into reusable package #3114