Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use link check from the CLI instead of an action #3625

Closed
wants to merge 11 commits into from

Conversation

rogermparent
Copy link
Contributor

@rogermparent rogermparent commented Jun 6, 2022

This PR changes our usage of our repo-link-check package in GitHub Actions to use its CLI interface instead of the checks-action-based reporting. The latter has always caused us a bunch of issues, one we always encounter being an issue with passing data around in PRs with huge diffs like #3396.

The output will be a little less friendly looking, but a slight trade-off in readability is worth the reliability IMO.

@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 6, 2022 22:17 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 6, 2022 22:28 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 6, 2022 22:53 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 04:51 Inactive
@yathomasi yathomasi mentioned this pull request Jun 7, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 19:51 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 19:59 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 20:48 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 20:59 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 22:03 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-cli-link-check-jgvkwbz June 7, 2022 22:18 Inactive
@rogermparent
Copy link
Contributor Author

I didn't realize the large diff issue wasn't due to GitHub Actions, but child_process.exec's buffer limitations. I can think of a few fixes to that, all involving a small upgrade to the link check package itself. I still think this is the way to go, but I'll shelve it for now until we add link-check to mlem.ai and get the VSCode extension released.

@rogermparent
Copy link
Contributor Author

Superceded by #3700

@yathomasi yathomasi deleted the cli-link-check branch July 11, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants