Fix broken blog social images #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Jun 12, 2022
| @@ -69,7 +69,7 @@ const BlogPostPage: React.FC<IBlogPostPageProps> = ({ data }) => { | |||
| image={ | |||
| picture && | |||
| (isProduction | |||
| ? `/blog/${picture.childImageSharp.fields.sourcePath}` | |||
| ? `/blog/images/${picture.childImageSharp.fields.sourcePath}` | |||
There was a problem hiding this comment.
The sourcePath at some point changed, breaking how we generated our social image paths. Maybe when #3396 was merged, but I'd need to debug further to be sure.
There was a problem hiding this comment.
Pretty sure it was 3396, I remember having to change something to do with sourcepath in order to fix a build-breaking issue
shcheklein
approved these changes
Jun 12, 2022
|
CSS lint tests are failing ... |
shcheklein
approved these changes
Jun 12, 2022
Yes, both CSS and JS lints tests are failing right now! Investing further right now but it doesn't have anything to do with this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.