-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guide: move Exp org patterns to Persisting Exps, improve #3178
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WDYT @shcheklein @iesahin ? Should we add some visual examples to each tab? |
It's visually nicer but I'm not sure this is a good way to use tabs. Tabs are used, in general, not for overlapping content but for clearly distinct alternatives: Programming languages, operating systems, etc. The reader sees the tabs more than the content inside them, so I'd use the tabs for content rather conservatively. |
Also, it becomes too much work to read all. We expect the reader to read and understand all these options, not select and apply one them. |
Not sure what overlapping means here. I think the org patterns are clear alternatives. I don't think we have to limit tabs use to languages or platforms although that's their original intention indeed. |
I don't have a strong opinion on this. I still think that both pages - index and overview should be significantly reconsidered (e.g. run cache on the index page is a way bigger problem), even organization patterns looks like out of the place for the index page - it's too specific information, or at least it's written this way. Point here is that most likely users won't understand this section anyway here, so no strong opinion on this :) I would move this into the Persisting experiments. Index and Overview - should be about bigger picture, general workflow diagrams, benefits, help users better navigate in the section stucture (map subsections to the workflow), etc. |
Agree. There's tasks for this in #2911 (updated with your notes).
Good idea ⌛ (slightly related: #2846 (review)) So assuming we put it there, what do we think about using tabs? And having "freed up some screen space" that way, about adding examples for each pattern?
I could move it elsewhere or remove it ⌛🧠 |
My feeling that it's not a very common pattern. I've not seen tabs being used this way. Usually tabs serve as a way to customize "same" content to my mind. |
2666892
to
f8b22d7
Compare
Running all pipelines page/section
f8b22d7
to
703dc24
Compare
Good stuff, Jorge, but before we review this, could you please help me with the context :): What was the intention behind this PR? (I see the link to making tabs, but title says different). I'm curios was the initial problem discussed somewhere, any specific motivation? PR itself:
|
It started as a first, exploratory attempt to apply tabs. But we also wanted to figure out what to do with this Experiment Organization Patterns section so that was a secondary objective, which is now the only goal left. Not a high priority probably
I updated the title after we decided not to use tabs but forgot to change the description... Done now. |
Fixed blur I think (still adapting to Macbook). The graph is from https://github.com/iterative/example-dvc-checkpoints/network ... do you mean that the labels don't seem to connect or that the style seems off? Not sure how to address the latter
Oops, removed links. Actually something in the site CSS won't let me make a full-width table. I tried this code and it shows it like this: And it has borders like the cards do so either way we need custom styles to remove those if that's what you meant. Lmk |
bc59944
to
c0aa2aa
Compare
Idk. We've discussed this a few times and seem to go in circles. The info. seems relevant but maybe
OK I tried incorporating some of the concepts in a304823, basically adding some more motivation to the section intro. |
Sorry catching up. RIP tabs. 😢 But I do understand the points why and making the info findable with CTRL F and from the internet is of supreme importance. ☝️ Quote is what I thought to. This image needs to be branded. Shall I make a thread for Roman @jorgeorpinel ? Also I think having a dedicated page for this is a good idea. Given the Reddit thread, maybe some blog posts with use cases on scenarios that you would use each way could be helpful? Like a series? This harkens back to Sami's "what is and experiment" presentation at the June Meetup too. |
Is it still an issue? I think it looks less odd now... Maybe I should just remove the Sep header and maybe add a caption linking to the source?
Yeah but we already have 7 pages in the Experiment Management guide so unless it's absolutely clear that this is a major exp-related topic I'd try to avoid that. |
it's still blurry ... also if we have somewhere commits tree image I would try to use the same style On separate page or making it part of the Overview/Index. I guess for me it's hard to connect intro like To me all these patterns are more general than persisting experiments after they done. It's more about how do you structure your project to accommodate experimentation in the first place. wdyt? |
I zoomed in as much as possible. I don't think we have any Git tree image other than custom made (2nd fig. here). If needed we can get the designer involved cc @jendefig
I agree. This is meant as an incremental improvement but the deeper iteration should be on the core product itself I believe, and probably the core team is thinking about it (cc @dberenbaum?). For now this is a good step forward IMO. |
I guess that's what I struggle a bit to see we had a section that was a bit more compact, arguably in a better place and now we have the same + some images (that ideally we would want to unify somehow). I'm not sure about this being an improvement to be honest. And text is confusing now since a bunch of those organizational patterns are not about |
└── experiments | ||
├── cnn_128 | ||
└── cnn_512 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of naming these cnn_128
, cnn_512
, etc. it may be more understandable to use the same words and common steps in an ML pipeline, like data augmentation
, dataset1
, dataset2
etc. cnn
is always in the training phase, and may be different versions of model
directory.
rel. #2939tree
-like folder views, Git tree pic, etc.)