Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: apply more language tabs #2939

Closed
2 of 12 tasks
jorgeorpinel opened this issue Oct 18, 2021 · 15 comments
Closed
2 of 12 tasks

docs: apply more language tabs #2939

jorgeorpinel opened this issue Oct 18, 2021 · 15 comments
Labels
good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 18, 2021

Follow up to #759

Per tabs system introduced in #2914

Usage

<!-- /some/page.md -->
<toggle>
<tab title="Foo">

some text about Foo

</tab>
<tab title="Bar">

some text about Bar

</tab>
</toggle>

Places where we can use them

Main use

Other ideas (exploratory)

@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions website: ux Website UI/UX labels Oct 18, 2021
@jorgeorpinel jorgeorpinel changed the title [SPIKE] tabs: use them! [SPIKE] lang-tabs: use them! Oct 18, 2021
@iesahin
Copy link
Contributor

iesahin commented Oct 20, 2021

Per OS instructions?

AWS etc. remote types?

@daavoo
Copy link
Contributor

daavoo commented Oct 20, 2021

I see the several dvc exp show flags #2877 as a good candidate for this format

@jorgeorpinel
Copy link
Contributor Author

Per OS instructions?

Yes but where? Or where first?

the several dvc exp show flags #2877 as a good candidate

Good idea, added to the list. Maybe not the most obvious or necessary though since those are actually different features, but it can surely help shorten some docs if needed.

@jorgeorpinel jorgeorpinel changed the title [SPIKE] lang-tabs: use them! Use language tabs Oct 30, 2021
@jorgeorpinel jorgeorpinel added C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement labels Oct 30, 2021
@jorgeorpinel jorgeorpinel changed the title Use language tabs SPIKE: Use language tabs Oct 30, 2021
@jorgeorpinel jorgeorpinel changed the title SPIKE: Use language tabs Where to use language tabs? Oct 30, 2021
@jorgeorpinel jorgeorpinel added the ❓ type: question Information is requested label Oct 30, 2021
@jorgeorpinel jorgeorpinel changed the title Where to use language tabs? [spike] where to use language tabs? Jan 6, 2022
@jorgeorpinel jorgeorpinel removed C: guide Content of /doc/user-guide C: ref Content of /doc/*-reference ❓ type: question Information is requested labels Jan 12, 2022
@jorgeorpinel jorgeorpinel changed the title [spike] where to use language tabs? docs: apply more language tabs Jan 12, 2022
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jan 12, 2022

Note: I updated the description with the list I came up with (forgot to let you all know earlier).

Try for the feature highlights in https://dvc.org/doc/use-cases/ci-cd-for-machine-learning

WDYT @casperdcl ?

Maybe exp list vs exp show or exp show vs exp diff in Comparing Exps? Per needs of #2995

WDYT @iesahin ?

To show different ways to Registering checkpoints

WDYT @flippedcoder ?

@shcheklein
Copy link
Member

What about Windows/Linux for code snippets - do we have this item in the list?

(seems the most obvious in DVC case)

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jan 12, 2022

What about Windows/Linux for code snippets

Good point. I didn't list that since we try to have pretty generic console samples but I'm sure lots of them are still very POSIX/GNU-specific. Added a top checkbox to review them and apply tabs where/if needed.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jan 12, 2022

Cc @tapadipti any places you think this could help condense https://dvc.org/doc/studio pages? E.g. any lists of anything that represent alternatives for some end could be candidates. Thanks

@iesahin
Copy link
Contributor

iesahin commented Jan 13, 2022

Maybe exp list vs exp show or exp show vs exp diff in Comparing Exps? Per needs of #2995

WDYT @iesahin ?

These commands are not "identical" in the sense that when you learn/use one, the other becomes obsolete. The use cases that we can employ these commands alternatively are limited. Also, our hidden content in other places causes confusion sometimes. I don't want these to be hidden behind tabs.

@jorgeorpinel
Copy link
Contributor Author

OK let's just keep it in mind as a possible way to make some sections shorted AFTER each command has been introduced and only if different commands are used as precise alternatives for some task/example.

@iesahin
Copy link
Contributor

iesahin commented Jan 14, 2022

IMO, we should limit tabs to:

  • Same commands in different shells/OSes
  • Same function in different languages/frameworks (e.g. DVCLive/checkpoints usage in Keras/PyTorch/...)

It's rare to have such uses in basic DVC commands, e.g., it's possible to get the list of remote experiments with ˋdvc exp showˋ but we normally use ˋdvc exp listˋ for this.

@tapadipti
Copy link
Contributor

Cc @tapadipti any places you think this could help condense https://dvc.org/doc/studio pages? E.g. any lists of anything that represent alternatives for some end could be candidates. Thanks

I just skimmed through the Studio docs, and currently I do not see sections with alternates that are suitable for placing in tabs, coz the Studio commands/instructions are the same across all platforms/OSes/etc. However, I think that as the doc evolves, there will be sections that can utilize tabs. Thanks @jorgeorpinel for tagging me.

@jorgeorpinel
Copy link
Contributor Author

IMO, we should limit tabs to...

OK. I'd generalize this rule of thumb to something you mentioned elsewhere @iesahin : Any list of alternatives where the reader only needs to see one (a clear favorite) to get the point. This probably means code/terminal examples 90% of the time at least but who knows, other situations may apply.

I updated the list in the description per this rule.

@shcheklein
Copy link
Member

Should we put summary of this into the docs contributing guide (also update it to describe how do these tabs in the Markdown)?

@jorgeorpinel
Copy link
Contributor Author

That is also a check box in the description @shcheklein 😬

@jorgeorpinel
Copy link
Contributor Author

Throughout Get Started code snippets (e.g. #3215)

Cc @iesahin

casperdcl added a commit that referenced this issue Feb 18, 2022
- related #2939
- related #1859
- related #2866
- related #1699
@jorgeorpinel jorgeorpinel removed the ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement label Apr 27, 2022
@jorgeorpinel jorgeorpinel removed the website: ux Website UI/UX label Jul 12, 2022
@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

6 participants