Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guide: Comparing Experiments #2862

Merged
merged 45 commits into from
Nov 4, 2021
Merged

guide: Comparing Experiments #2862

merged 45 commits into from
Nov 4, 2021

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Sep 28, 2021 •
edited by jorgeorpinel
Loading

Adds a section to the UG about dvc exp list, dvc exp show and dvc exp diff.

Closes #2737
Fixes #2860

@iesahin iesahin added the C: guide Content of /doc/user-guide label Sep 28, 2021
@iesahin iesahin self-assigned this Sep 28, 2021
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi September 28, 2021 16:05 Inactive
@restyled-io restyled-io bot mentioned this pull request Sep 28, 2021
Merged
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi September 28, 2021 17:02 Inactive
@jorgeorpinel

This comment has been minimized.

Sign in to view
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi October 2, 2021 13:05 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi October 4, 2021 09:41 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi October 4, 2021 10:52 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Oct 4, 2021
Closed
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi October 5, 2021 10:03 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi October 5, 2021 14:34 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi October 5, 2021 14:40 Inactive
@restyled-io restyled-io bot mentioned this pull request Nov 2, 2021
Merged
@jorgeorpinel jorgeorpinel mentioned this pull request Nov 3, 2021
Closed
15 tasks
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi November 3, 2021 09:59 Inactive
@jorgeorpinel
Copy link
Contributor

Could you point to the place where these regexes are?

@iesahin https://github.com/iterative/link-check/blob/master/src/scrapeLinks.ts

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--2texsi November 4, 2021 02:57 Inactive
jorgeorpinel
jorgeorpinel reviewed Nov 4, 2021
View reviewed changes
content/docs/user-guide/experiment-management/comparing-experiments.md

### Get the comparison in Markdown table format

`dvc exp diff` has also an option to output a [Github-Flavored Markdown][gfm]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is the line that makes the link checker fail. I removed it and it's passing now. Will re-add it though (we can merge as-is)

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--2texsi November 4, 2021 03:01 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--2texsi November 4, 2021 05:22 Inactive
jorgeorpinel
jorgeorpinel approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@restyled-io restyled-io bot mentioned this pull request Nov 4, 2021
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-iesahin-ug-exp--2texsi November 4, 2021 05:26 Inactive
@restyled-io restyled-io bot mentioned this pull request Nov 4, 2021
Merged
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--2texsi November 4, 2021 10:32 Inactive
@iesahin iesahin merged commit 02b6136 into master Nov 4, 2021
@iesahin iesahin deleted the iesahin/ug-exp-comparing branch November 4, 2021 10:34
This was referenced Nov 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermparent rogermparent rogermparent left review comments

@dberenbaum dberenbaum dberenbaum left review comments

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees

@iesahin iesahin

Labels
C: guide Content of /doc/user-guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

guide: --json/csv examples in Listing/Comparing Experiments guide: Comparing Experiments
5 participants
@iesahin @jorgeorpinel @shcheklein @rogermparent @dberenbaum