Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add margin-bottom to toggle component #181

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add margin-bottom to toggle component #181

merged 1 commit into from
Jan 13, 2022

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Jan 12, 2022 •
edited
Loading

Got a styling issue @julieg18 . Maybe someone in the web team can update the margin of the tabs section so there is some white space before the next paragraph? Currently it's gray -- looks odd:

- @jorgeorpinel in dvc.org#3178

Already merged pr for this in dvc.org!

@julieg18 julieg18 self-assigned this Jan 12, 2022
@shcheklein shcheklein temporarily deployed to cml-dev-add-toggle-marg-pi8nll January 12, 2022 22:36 Inactive
yathomasi
yathomasi approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@yathomasi yathomasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@julieg18 julieg18 merged commit 502b989 into master Jan 13, 2022
@julieg18 julieg18 deleted the add-toggle-margin branch January 13, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yathomasi yathomasi yathomasi approved these changes

@rogermparent rogermparent rogermparent approved these changes

Assignees

@julieg18 julieg18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julieg18 @rogermparent @yathomasi @shcheklein