-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc.lock updates #2139
dvc.lock updates #2139
Conversation
@@ -364,7 +364,11 @@ validation and auto-completion. | |||
> See also | |||
> [How to Merge Conflicts](/doc/user-guide/how-to/merge-conflicts#dvcyaml). | |||
|
|||
### Output entries | |||
### Simple output entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I don't like this term "simple". There is nothing specifically simple or complex about those entries. It's totally fine to have them defined differently, with a bit different schema if we very clear in docs about this.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my mind we are already in the section that describes the dvc.yaml schema and ideally it should be clear from the context that this is about dvc.yaml
. I can see how additional message can help, but anything that comes to my mind would create even more confusion (people are not aware about other files, different types of outputs, etc).
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I simplified by calling the section in dvc.yaml "Output subfields" (which is what it is), PTAL.
If it's still confusing we could consider calling the sections in .dvc "Output/Dependency tracking entries".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. TBH the ideal solution would be to have tables inside tables but that's not doable on md, would need some design and frontend work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good!
OK, merging then 🙂 |
Continuing #2131