-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema keywords in lockfile #2131
Conversation
This is a 2.0 change introduced in iterative/dvc#5222
- model-uk.hdfs | ||
- path: model-uk.hdfs | ||
md5: 17b3d1efc339b416c4b5615b1ce1b97e | ||
size: 2712300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, they are OK in the latter example but I'll remove it from here to simplify. I'll make a follow-up PR to explain the size
(and nfiles
?) fields in dvc.lock.
size: 2712300 |
UPDATE: See #2139
Thanks @skshetry ! |
p.s. we may also need to follow-up with an update to all other dvc.lock samples throughout docs... UPDATE: See #2139 |
This is a 2.0 change introduced in iterative/dvc#5222.
Though there wasn't
stages
keyword indvc.lock
file in 1.0 version, I found a couple of files that had them. But,schema
andstages
were introduced at the same time.schema
is just set to 2.0 when DVC v2.0 tries to dump into the lockfile. v1.0 lockfiles are migrated at the same time if needed, to v2.0.stages
just wrap the pre-existing structure of lock entries.In 1.0
In 2.0
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏