-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvc.lock updates #2139
Merged
Merged
dvc.lock updates #2139
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6ccea9e
cmd: std chkig/metrics/params --all option text
jorgeorpinel f947ea1
Merge branch 'master' into jorge
jorgeorpinel a29bc4e
2 typos
jorgeorpinel 6c1e577
cmd: improve note about traversing dvc.yaml files in status,repro
jorgeorpinel e44c838
Merge branch 'master' into jorge
jorgeorpinel 202084a
misc term updates
jorgeorpinel 14ea7c2
Merge branch 'master' into jorge
jorgeorpinel 9fc0e18
cmd: update destroy
jorgeorpinel 780ae14
Merge branch 'master' into jorge
jorgeorpinel 8a3ac57
Merge branch 'master' into jorge
jorgeorpinel 573ac04
dvc.lock: update samples t/o docs
jorgeorpinel 166eb7a
Merge branch 'master' into jorge
jorgeorpinel 5b7cd57
guide: complete output entry info for dvc.lock
jorgeorpinel b279058
guide: simplify dvc.yaml vs .lock outs/deps subspecs
jorgeorpinel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I don't like this term "simple". There is nothing specifically simple or complex about those entries. It's totally fine to have them defined differently, with a bit different schema if we very clear in docs about this.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my mind we are already in the section that describes the dvc.yaml schema and ideally it should be clear from the context that this is about
dvc.yaml
. I can see how additional message can help, but anything that comes to my mind would create even more confusion (people are not aware about other files, different types of outputs, etc).This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I simplified by calling the section in dvc.yaml "Output subfields" (which is what it is), PTAL.
If it's still confusing we could consider calling the sections in .dvc "Output/Dependency tracking entries".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. TBH the ideal solution would be to have tables inside tables but that's not doable on md, would need some design and frontend work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good!