Regular updates & plots 1.0 update #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are out of testsChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
20 tasks
jorgeorpinel
changed the title
This was referenced Jun 1, 2020
Merged
|
Actually not totally ready for review. All the plots examples may be outdated 😕
|
shcheklein
reviewed
Jun 1, 2020
shcheklein
reviewed
Jun 1, 2020
jorgeorpinel
commented
Jun 2, 2020
shcheklein
reviewed
Jun 10, 2020
shcheklein
reviewed
Jun 10, 2020
| ``` | ||
|
|
||
| ## Description | ||
|
|
||
| This command provides a quick way to visualize metrics such as loss functions, | ||
| AUC curves, confusion matrices, etc. Please see `dvc plots` for information on | ||
| the supported data formats and other relevant details about DVC plots. | ||
| AUC curves, confusion matrices, etc. All plots defined in `dvc.yaml` are used by |
There was a problem hiding this comment.
All plot files are used ... ?
There was a problem hiding this comment.
That's what the usage says last time I checked. I'm also not sure how this works though, changes to core keep happening too so we can probably follow up on this in #1414 — added a bullet
shcheklein
reviewed
Jun 10, 2020
shcheklein
requested changes
Jun 10, 2020
pared
reviewed
Jun 10, 2020
Comment on lines
+26
to
+27
| > Note that unlike `dvc metrics diff`, this command does not calculate numeric | ||
| > differences between metric file values. |
pared
reviewed
Jun 10, 2020
pared
approved these changes
Jun 10, 2020
|
OK so actually this PR is blocking at least 2 more down the line (the ones for add and run). Can we try to merge it and extract pending details into #1414 @shcheklein ? Thanks |
Sure, I'm happy to focus on this one exclusively (and we should have probably do that yesterday) and get it done - there are no major things left. |
|
Merged this, let's address left overs (if any as we go) |
shcheklein
pushed a commit
that referenced
this pull request
Jun 11, 2020
* cmd ref: add note that move creates dirs * cmd ref: improve structure of add ref desc. * grammar: add some commas * term: checksum -> hash value in dvcignore guide * style: lower case bullet text * cmd ref: remove some redundancy in metrics index * cmd ref: update plots refs synopsis and descriptions per iterative/dvc/issues/3924 et al. * Add plots modify cmd * typo: CSV->csv * term: working tree -> workspace per iterative/dvc/pull/3914 * cmd ref: couple improvements to add ref per #1382 (review) and #1382 (review) * Update config/prismjs/dvc-commands.js * cmd ref: update plots modify description * cmd ref: add plots modify to nav, with a few more improvements * cmd ref: plots --show-json -> --show-vega per iterative/dvc#3891 (comment) * rename x-lab to x-label * cmd ref: review descriptions of plots index, show, and diff * cmd ref: review and update old plots cmds options per iterative/dvc#3948 et al. * cmd ref: a couple more option updates per #1382 (review) * cmd ref: emphasize add works with any large file/dir per #1382 (review) * cmd ref: updae plots modify top half (definition, description) per #1382 (review) al. * cmd ref: improve all plot cmd option descriptions * Update content/docs/command-reference/plots/modify.md * cmd ref: review examples (mainly images) in plots modify per #1382 (comment) et al. * cmd ref: rephrase info about how data arrays are injected to plot templates per #1382 (review) * cmd ref: update info on how targets for for plots show/diff per #1382 (review) * cmd ref: double check all plots examples per #1382 (comment) * cmd ref: remove info about plots show --select * cmd ref: update add desc per #1382 (review) * cmd ref: re-explain dvc add for dirs per #1382 (review) * cmd ref: improve description about targets in plots diff per #1382 (review) * cmd ref: make emoji note in plots index per #1382 (review) * cmd ref: remove ineffective CSV code block highlighting from plots refs per #1382 (review) * get started: improve intro in index * glossary: remove external deps entry (no need) * cmd ref: update add for 1.0 (1) up to... before Examples * cmd ref: 1.0 updates for add (2) - examples * cmd ref: remove note about comments in add example per #1411 (review) Co-authored-by: Dmitry Petrov <[email protected]>
2 tasks
jorgeorpinel
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dvc runcmd ref.dvc metrics/plotsfor 1.0 release, started in metrics: 1.0 update #1360UPDATE: Jump to
#1382 (comment)#1382 (comment) for pending questions/items.