Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regular updates & plots 1.0 update #1382
Regular updates & plots 1.0 update #1382
Changes from 50 commits
8030c46
5bffb49
431ffc0
3f2d554
86b8f62
b75f314
47ad311
2f1e09c
3a723a0
bc54b22
177de9b
f59eea9
c73f7c0
140608c
0028b53
8e572a5
434fe96
5108e14
fba18c3
a75dda2
30493ab
d33aecc
e385a02
22b648c
f3cba9c
532184b
4d9cd71
791dbd2
697ab77
3eb3858
90cac8e
94027c5
19fbe99
c51e2ad
13dce7c
3a418f6
4729c0d
5a92508
aa620cc
1357d22
74c5234
9e26518
0bfb2ad
ae1d911
da639ef
a467891
f6a2e4f
a613233
ba94d6d
0d5f502
439f8e0
7bce905
edd0323
c0ce897
6bcf06d
b0f49c3
471a565
9169967
de9110a
1bcae8d
2c50676
dc0725c
1970fc3
cd602c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does
/to
part mean?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That you can chose the from revision and also the to revision(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm ... feels really weird
why just "Git commits to read metrics from to plot" is not enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went for
Git commits to find metrics to diff
for now (in d22c9c6). Cc @efiopThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: Actually I changed
diff
forcompare
in edd0323There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's write a sentence or two that it's not a "difference" - it's just multiple graphs on the same plot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. If it's not a difference though, what's the point of having 2 commands for showing plots? This one could be renamed show (supporting multiple revisions) and current show deprecated, no? WDYT @efiop cc @dmpetrov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted that diff is not a real diff in 6bcf06d for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. found a parallel ongoing discussion related to this in iterative/dvc#3963 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted as an extra bullet in #1414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omit "Note that" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(it's not a Note at the moment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a block quote, correct. But it's a note as in: it's a small detail we want to make sure the reader notes.
We have another 49 instances of "Note that" in docs that are not in a block quote 😬