Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: example on modifying any outputs into a plots #1946

Merged
merged 6 commits into from
Nov 22, 2020
Merged

Conversation

imhardikj
Copy link
Contributor

@imhardikj imhardikj commented Nov 15, 2020

Partially Addresses #1414

@shcheklein shcheklein temporarily deployed to dvc-landing-plotscmd-kdw3xfowb November 15, 2020 11:42 Inactive
@imhardikj

This comment has been minimized.

@imhardikj imhardikj marked this pull request as ready for review November 18, 2020 07:17
@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel changed the title cmd ref: pending plots changes by 1.0 release cmd: example on modifying an outputs into a plots Nov 18, 2020
@shcheklein shcheklein temporarily deployed to dvc-landing-plotscmd-kdw3xfowb November 19, 2020 20:24 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! A few more comments added ☝️

@shcheklein shcheklein temporarily deployed to dvc-landing-plotscmd-kdw3xfowb November 21, 2020 18:27 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple details left before we can merge this, but it looks ready! Thanks @imhardikj

@@ -30,6 +30,10 @@ Property names are passed as [options](#options) to this command (prefixed with
`--`). These are based on the full
[Vega specification](https://vega.github.io/vega/docs/specification/).

Note that a secondary use of this command is to convert output or simple
`dvc metrics` file into a plots file (see
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dvc metrics file

I like this, we should probably apply in other places where manual links to "plots/metrics file(s)" exist. (In another PR).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't worry about it @imhardikj, I'll take care of that.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-plotscmd-kdw3xfowb November 22, 2020 23:38 Inactive
@jorgeorpinel jorgeorpinel merged commit 3ae78e2 into master Nov 22, 2020
@jorgeorpinel jorgeorpinel deleted the plotscmd branch November 28, 2020 00:42
@jorgeorpinel jorgeorpinel changed the title cmd: example on modifying an outputs into a plots cmd: example on modifying any outputs into a plots Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants