Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd-ref: document checkout displaying changes #1054

Merged
merged 11 commits into from
Apr 22, 2020
Merged

Conversation

skshetry
Copy link
Member

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please chose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

iterative/dvc#3401 is under review. I have kept this docs to minimum, as the PR is more in relation with UI than any behavioral change. But. I see that, the behavior that it would checkout silent if there's an error was mentioned, which I have adjusted a bit. Also, some places look good to show outputs of dvc checkout.

@skshetry skshetry added the A: docs Area: user documentation (gatsby-theme-iterative) label Mar 16, 2020
@skshetry skshetry self-assigned this Mar 16, 2020
@shcheklein shcheklein temporarily deployed to dvc-landing-skshetry-ch-rne5ln March 16, 2020 09:20 Inactive
@jorgeorpinel

This comment has been minimized.

@skshetry skshetry force-pushed the skshetry/checkout-pr branch from 20ec6ac to c4f968c Compare March 24, 2020 13:41
@skshetry skshetry changed the title [WIP] cmd-ref: document checkout displaying changes cmd-ref: document checkout displaying changes Mar 24, 2020
@skshetry skshetry marked this pull request as ready for review March 24, 2020 13:41
@skshetry skshetry force-pushed the skshetry/checkout-pr branch from c4f968c to 6da4ccc Compare March 24, 2020 13:42
@skshetry
Copy link
Member Author

skshetry commented Mar 24, 2020

I tried adding outputs of dvc checkout, but my internet has really taken a hit lately. And, I don't think, it matters much at the moment. So, I have rollbacked this to only document reference.

@skshetry skshetry requested a review from jorgeorpinel March 24, 2020 13:44
@shcheklein
Copy link
Member

@skshetry could we at least remove existing wrong outputs (if any)? Or all of them silent now?

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things but I also think we should def. review all the instances of dvc checkout usage in sample console blocks and remove any outdated output or, if relevant, update it with the current version's output.

We could take this over if needed.

content/docs/command-reference/checkout.md Outdated Show resolved Hide resolved
content/docs/command-reference/checkout.md Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-landing-skshetry-ch-pneifv March 25, 2020 18:22 Inactive
@shcheklein
Copy link
Member

@skshetry @jorgeorpinel what is the status of this, guys?

@jorgeorpinel
Copy link
Contributor

@shcheklein idk but I just committed my suggestions since this has been waiting for a long time now. Should we take it over? Or we can merge it and open a separate issue for

could we at least remove existing wrong outputs (if any)? Or all of them silent now?

@skshetry
Copy link
Member Author

skshetry commented Apr 6, 2020

@jorgeorpinel, @shcheklein, sorry, this got lost in my notifications. AFAICT the docs do not have any outputs on checkouts (and, as checkouts were silent before), so, we don't need to change other parts.

@shcheklein
Copy link
Member

@jorgeorpinel yes, let's take this over and update checkout outputs. I would not do this everywhere - only in places where checkout is the topic of a section/paragraph.

@jorgeorpinel

This comment has been minimized.

@shcheklein shcheklein temporarily deployed to dvc-landing-skshetry-ch-ryxfvq April 8, 2020 16:23 Inactive
@skshetry

This comment has been minimized.

jorgeorpinel
jorgeorpinel previously approved these changes Apr 9, 2020
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we at least remove existing wrong outputs (if any)? Or all of them silent now?

There's already no output samples for dvc checkout in code blocks... We can merge this!

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-skshetry-ch-ryxfvq April 9, 2020 05:28 Inactive
@jorgeorpinel
Copy link
Contributor

I did merge master since this branch is kind of old, and updated the main example in the checkout cmd ref (including the actual command output).

@jorgeorpinel jorgeorpinel requested a review from shcheklein April 9, 2020 05:29
@shcheklein

This comment has been minimized.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, see a few comments

@shcheklein

This comment has been minimized.

@jorgeorpinel jorgeorpinel requested a review from shcheklein April 18, 2020 04:28
@jorgeorpinel jorgeorpinel dismissed their stale review April 18, 2020 04:28

I took over this PR.

@shcheklein

This comment has been minimized.

@shcheklein

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor

at least data versioning use case and tutorial should benefit from adding dvc checkout outputs

Done in a819927 (for all use cases)

Also solved merge conflicts now.

@jorgeorpinel jorgeorpinel requested a review from shcheklein April 22, 2020 22:01
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor typo

content/docs/command-reference/checkout.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants