Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular updates (Apr 16) #1160

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Regular updates (Apr 16) #1160

merged 3 commits into from
Apr 21, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Apr 16, 2020 •
edited
Loading

@jorgeorpinel jorgeorpinel mentioned this pull request Apr 16, 2020
Closed
@shcheklein shcheklein temporarily deployed to dvc-landing-2020-04-16-xhczkn3 April 16, 2020 22:52 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-16-xhczkn3 April 17, 2020 03:15 Inactive
jorgeorpinel
jorgeorpinel commented Apr 17, 2020
View reviewed changes
content/docs/command-reference/metrics/add.md
Comment on lines -109 to +107
type: raw
type: json
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Apr 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is correct right @dmpetrov? See https://dvc.org/doc/command-reference/metrics/add#examples

I'm also removing all mentions of raw type metrics, per iterative/dvc#3626 (review).

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-16-xhczkn3 April 17, 2020 04:32 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review April 17, 2020 04:34
@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
@shcheklein
Copy link
Member

@jorgeorpinel merging this?

@jorgeorpinel
Copy link
Contributor Author

Yes, thanks.

@jorgeorpinel jorgeorpinel merged commit 40bd8f4 into master Apr 21, 2020
@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
@jorgeorpinel jorgeorpinel deleted the 2020-04-16 branch May 5, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeorpinel @shcheklein