Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout/pull should write a summary of the working space changes #1838

Closed
shcheklein opened this issue Apr 6, 2019 · 6 comments
Closed
Assignees
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@shcheklein
Copy link
Member

Now it writes the same message:

Preparing to collect status from https://remote.dvc.org/get-started
[##############################] 100% Collecting information
[##############################] 100% Analysing status.
[##############################] 100% Checkout finished!

Everything is up to date.

no matter if something changed or not. It's hard to see if it actually update the working space. I would suggest to write summary, similar to the way git is doing when you pull/push something.

@efiop efiop added enhancement Enhances DVC p2-medium Medium priority, should be done, but less important labels Apr 6, 2019
@ghost ghost added the ui user interface / interaction label Apr 6, 2019
@shcheklein
Copy link
Member Author

Now w/o a progress bar it's even worse - Everything is up to date. for dvc pull and an empty output for the dvc checkout. I even though for a moment that I didn't know how dvc pull works and went to check the docs, before I realized that something is actually happening, it's changing something.

@jorgeorpinel
Copy link
Contributor

Seems like both @bhavaniravi and @leehanchung also reported this in #2667 and #2838, respectively. Their comments:

When I do a dev pull and the data is fetched I don't get any response saying Sucess I have do a ls to verify whether the data folder has been created


(base) PS B:\user\example-get-started> ls .\data\

    Directory: B:\user\example-get-started\data

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----       11/22/2019  12:52 PM             11 .gitignore
-a----       11/22/2019  12:52 PM            155 data.xml.dvc

(base) PS B:\user\example-get-started> dvc pull
Everything is up to date.
(base) PS B:\user\example-get-started> ls data

    Directory: B:\user\example-get-started\data
Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----       11/22/2019  12:52 PM             11 .gitignore
-a----       11/22/2019   2:52 PM       37916850 data.xml
-a----       11/22/2019  12:52 PM            155 data.xml.dvc

basically it doesnt tell what is pulled/changed at the moment.
And i do see a point of doing it none-verbose-ly if the dataset contains thousands of images inside a directory. :p

@casperdcl
Copy link
Contributor

so should #2667 be closed as a duplicate?

@jorgeorpinel
Copy link
Contributor

Idk. Already asked over there. Ivan and Ruslan have a long conversation in there, so let them decide.

@efiop
Copy link
Contributor

efiop commented Nov 23, 2019

Closed #2667 in favor of this one. Thanks for the heads up!

@efiop
Copy link
Contributor

efiop commented Dec 7, 2020

Fixed by iterative/dvc.org#1054

@efiop efiop closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

4 participants