Create test-deploy.yml

[casperdcl]

• merge Create test.yml #526 & Improve the release workflow #528 (merging this PR will auto-mark Create test.yml #526 and Improve the release workflow #528 as merged)

  • Fixes Tests fail within external PRs #183 and [fixes (partially)] lint and test are missing in GH workflow #522; requires the configuration of a GitHub Environment
  • Extend release.yml to perform dry runs on pull requests to make sure that the new code is deliverable
  • Embed dependancron in the release workflow, making sure that images are always up to date to the major versions
  • Build containers using the latest major version from npm after publishing

• make test & deploy/release interdepended, removing need for duplication (Create test.yml #526 (review))
• reorder matrix deps for consistency (CML-DVC-BASE-GPU)
• cache docker layers rather than rebuild from scratch (Improve the release workflow #528 (comment), https://github.com/docker/build-push-action#customizing)

---

• closes Create test.yml #526
  • fixes Tests fail within external PRs #183
  • fixes (partially) lint and test are missing in GH workflow #522
• closes Improve the release workflow #528

[0x2b3bfa0]

• Technically approved: solves the problem.
• Graphically approved: the dependency graph looks awesome! 😄
• Philosophically (quasi) approved: minor concerns at Create test.yml #526 (comment).

I personally find merging the two workflows a bit extreme, but everything looks great otherwise. Feel free to merge after reading the linked comment.

[casperdcl]

Replied to #526 (comment) there.

I personally find merging the two workflows a bit extreme

I've discussed this with GitHub support and their official stance is that the needs: workflow key is intended for this and unfortunately that means things need to be defined in the same workflow file. They also don't support true YAML so there's no neat way to inject interdependencies.

Do you like graphs? https://github.com/tqdm/tqdm/actions/runs/777757936

[0x2b3bfa0]

I've discussed this with GitHub support and their official stance is that the needs: workflow key is intended for this and unfortunately that means things need to be defined in the same workflow file. They also don't support true YAML so there's no neat way to inject interdependencies.

So true! Let's hope it changes soon.

Do you like graphs? https://github.com/tqdm/tqdm/actions/runs/777757936

Yum! 😋 That's hard to resist.

The only practical concern I have is that depending on the test job will cause all the release runs (even the cron ones) to require a manual approval through GitHub Environments. If that's good enough for us,

[casperdcl]

I'm not a fan of the manual approval stuff. Skipping things when there are no credentials (and failing when there's a release with no credentials) seems a better approach to me. Was there some other intention?

[0x2b3bfa0]

cache docker layers rather than rebuild from scratch

Given that the RUN commands are always the same for a major version, how will we know when to use the cached layers and when to refresh them?

cml/Dockerfile

Lines 69 to 74 in 3736d7f

	RUN cd /etc/apt/sources.list.d \
	&& wget https://dvc.org/deb/dvc.list \
	&& apt-get update \
	&& apt-get install --yes "dvc=${DVC_VERSION}.*" \
	&& apt-get clean \
	&& rm --recursive --force /var/lib/apt/lists/*

[DavidGOrtega]

This is becoming a monumental PR. Too much to review here.
What it's important is that we need the acceptance test prior to merge and the build. Right now everything looks very nice to me. Im going to do a full trial

[casperdcl]

merging as a "hotfix" (doesn't affect CML JS core) before this bloats more. Also to get the caching into master. Also to lay #526, #528 and #183 to rest.

75% to 50% faster Docker builds! 4min down to <60sec, and 6min down to 3min! ⏩