Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint and test are missing in GH workflow #522

Closed
DavidGOrtega opened this issue May 15, 2021 · 2 comments · Fixed by #539
Closed

lint and test are missing in GH workflow #522

DavidGOrtega opened this issue May 15, 2021 · 2 comments · Fixed by #539
Assignees
Labels
p0-critical Max priority (ASAP) technical-debt Refactoring, linting & tidying

Comments

@DavidGOrtega
Copy link
Contributor

We have removed the ability to pass the tests and linter in dev branches to warranty the healthiness of the code we pretend to merge or accept PRs

npm run lint
npm run test

also checkbot has some inline comments that should be removed or investigate why they have been commented

#cml-send-comment report.md
#cml-send-github-check report.md
@DavidGOrtega DavidGOrtega added p0-critical Max priority (ASAP) technical-debt Refactoring, linting & tidying labels May 15, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this May 16, 2021
@0x2b3bfa0
Copy link
Member

#cml-send-comment report.md
#cml-send-github-check report.md

Uncommenting the cml-send-comment line doesn't cause any error, and the command produces the expected results. The cml-send-github-check line seems to produce the following error:

$ REPO_TOKEN=${{secrets.TEST_GITHUB_TOKEN}} cml-send-github-check report.md
RequestError [HttpError]: You must authenticate via a GitHub App.

@0x2b3bfa0
Copy link
Member

Fixed with #539: it only works with the session-specific GITHUB_TOKEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0-critical Max priority (ASAP) technical-debt Refactoring, linting & tidying
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants