Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail within external PRs #183

Closed
DavidGOrtega opened this issue Jul 29, 2020 · 1 comment · Fixed by #530
Closed

Tests fail within external PRs #183

DavidGOrtega opened this issue Jul 29, 2020 · 1 comment · Fixed by #530
Labels
technical-debt Refactoring, linting & tidying

Comments

@DavidGOrtega
Copy link
Contributor

External PRs does not pass the tests due to token autentication

 ● CML e2e › cml-send-comment

    Command failed: node ./bin/cml-send-comment.js comment.md
    Resource not accessible by integration

log here
@DavidGOrtega DavidGOrtega added the good-first-issue Good for newcomers (good-first-issue) label Jul 29, 2020
@DavidGOrtega DavidGOrtega mentioned this issue Oct 5, 2020
Closed
@DavidGOrtega DavidGOrtega added technical-debt Refactoring, linting & tidying and removed good-first-issue Good for newcomers (good-first-issue) labels Mar 8, 2021
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Apr 5, 2021 •
edited
Loading

This looks like a good use case for GitHub Environments, and a logic addition to the changes required by #217.

@0x2b3bfa0 0x2b3bfa0 mentioned this issue Apr 27, 2021
Merged
This was referenced May 16, 2021
Closed
Closed
@casperdcl casperdcl mentioned this issue May 17, 2021
Merged
@aornugent aornugent mentioned this issue Jul 3, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create test-deploy.yml iterative/cml
Create test.yml iterative/cml
2 participants
@DavidGOrtega @0x2b3bfa0