generated from it-at-m/oss-repository-en-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move duplicate s3 logic to client libs #1442
Labels
Comments
1 task
This was referenced Mar 12, 2024
Closed
4 tasks
markostreich
changed the title
Create a s3 adapter lib
Move duplicate logic to client libs
Mar 15, 2024
simonhir
changed the title
Move duplicate logic to client libs
Move duplicate s3 logic to client libs
Mar 15, 2024
markostreich
added
digiwf-integrations
refactoring
and removed
enhancement
New feature or request
labels
Apr 26, 2024
10 tasks
MR für das Ops-Repo https://git.muenchen.de/digitalisierung/digiwf/digiwf-ops/-/merge_requests/447 |
lehju
pushed a commit
that referenced
this issue
Jun 6, 2024
* 1442 refactor file type validation * 1442 refactor file type validation * 1442 fix S3FileTransferRepositoryTest * 1442 return of extensions without dot, fix unittests * 1442 config document-storage-url * 1442 adjust properties for S3 client configuration * 1442 domain specific s3 storage can be used in dms integration service * 1442 fix task service itests * 1442 fix s3 adapter test for ticket integration * 1442 S3 domain specific url for dms; refactoring engine + tasklist * 1442 refactor properties, beautifications * remove temporary example * 1442 fix s3 security configuration * 1442 remove redundant import * #1442: fix ticket integration
Leider gibt es noch einen Fehler in der Engine entdeckt. Die |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In the past we created presigned urls asynchronously with the s3 integration and passed them to the integration.
With the dms and zammad integration we changed that concept: The integrations now get the filepath in s3 storage and the integrations synchronously create presigned urls.
With the new concept we create for each integration new S3Adapters with very similar functionalities.
Describe the solution you'd like
The duplicate s3 logic should be correctly moved to the corresponding client libs.
This includes following logic:
Acceptance Criteria
References
The text was updated successfully, but these errors were encountered: