Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move duplicate s3 logic to client libs #1442

Closed
3 tasks done
lmoesle opened this issue Mar 11, 2024 · 2 comments · Fixed by #1684
Closed
3 tasks done

Move duplicate s3 logic to client libs #1442

lmoesle opened this issue Mar 11, 2024 · 2 comments · Fixed by #1684

Comments

@lmoesle
Copy link
Contributor

lmoesle commented Mar 11, 2024

Is your feature request related to a problem? Please describe.

In the past we created presigned urls asynchronously with the s3 integration and passed them to the integration.
With the dms and zammad integration we changed that concept: The integrations now get the filepath in s3 storage and the integrations synchronously create presigned urls.

With the new concept we create for each integration new S3Adapters with very similar functionalities.

Describe the solution you'd like

The duplicate s3 logic should be correctly moved to the corresponding client libs.
This includes following logic:

  • Filetype validation
  • Domain specific s3 storage

Acceptance Criteria

  • Support Filetype validation/filtering via s3 client lib
  • Support direct get of domain specific s3 via process config client lib
  • The key for the domain specific s3 in the process config is only defined in the library

References

@darenegade darenegade added the enhancement New feature or request label Mar 14, 2024
@markostreich markostreich changed the title Create a s3 adapter lib Move duplicate logic to client libs Mar 15, 2024
@simonhir simonhir changed the title Move duplicate logic to client libs Move duplicate s3 logic to client libs Mar 15, 2024
@lehju lehju self-assigned this Apr 3, 2024
@markostreich markostreich assigned markostreich and unassigned lehju Apr 18, 2024
@markostreich markostreich added digiwf-integrations refactoring and removed enhancement New feature or request labels Apr 26, 2024
@markostreich markostreich linked a pull request May 15, 2024 that will close this issue
10 tasks
@markostreich
Copy link
Contributor

@markostreich markostreich mentioned this issue May 17, 2024
10 tasks
lehju added a commit that referenced this issue Jun 5, 2024
@simonhir simonhir mentioned this issue Jun 6, 2024
5 tasks
lehju pushed a commit that referenced this issue Jun 6, 2024
* 1442 refactor file type validation

* 1442 refactor file type validation

* 1442 fix S3FileTransferRepositoryTest

* 1442 return of extensions without dot, fix unittests

* 1442 config document-storage-url

* 1442 adjust properties for S3 client configuration

* 1442 domain specific s3 storage can be used in dms integration service

* 1442 fix task service itests

* 1442 fix s3 adapter test for ticket integration

* 1442 S3 domain specific url for dms; refactoring engine + tasklist

* 1442 refactor properties, beautifications

* remove temporary example

* 1442 fix s3 security configuration

* 1442 remove redundant import

* #1442: fix ticket integration
@lehju lehju reopened this Jun 6, 2024
@markostreich
Copy link
Contributor

markostreich commented Jun 14, 2024

Leider gibt es noch einen Fehler in der Engine entdeckt. Die S3Configuration wird nicht rechtzeitig getriggert, sodass die Default-Implementierung startet und die Engine keine domain spezifischen S3 URLs zurückgibt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants