Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(#1266): zammad file attachments #1389

Merged
merged 20 commits into from
Mar 14, 2024

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Feb 29, 2024

Description

Allow users to attach files to zammad tickets

Reference

Issues: closes #1266

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 80.32787% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 42.80%. Comparing base (48f7195) to head (ba3d143).
Report is 5 commits behind head on dev.

❗ Current head ba3d143 differs from pull request most recent head de4506c. Consider uploading reports for the commit de4506c to get more accurate results

Files Patch % Lines
...f/ticket/integration/adapter/out/s3/S3Adapter.java 72.22% 9 Missing and 1 partial ⚠️
...t/integration/application/WriteArticleUseCase.java 80.00% 0 Missing and 1 partial ⚠️
...f/ticket/integration/domain/model/FileContent.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1389      +/-   ##
============================================
+ Coverage     42.37%   42.80%   +0.43%     
- Complexity     1546     1585      +39     
============================================
  Files           632      640       +8     
  Lines          9181     9303     +122     
  Branches        452      452              
============================================
+ Hits           3890     3982      +92     
- Misses         5136     5160      +24     
- Partials        155      161       +6     
Flag Coverage Δ
unittests 42.80% <80.32%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmoesle lmoesle force-pushed the feature/#1266-zammad-file-attachments branch from e9cee19 to 3a04b66 Compare March 1, 2024 13:00
@lmoesle lmoesle changed the title feature(#1266): adjust element templates and example process feature(#1266): write articles with file attachments in ticket integration Mar 5, 2024
@lmoesle lmoesle changed the title feature(#1266): write articles with file attachments in ticket integration feature(#1266): zammad file attachments Mar 5, 2024
@lmoesle lmoesle force-pushed the feature/#1266-zammad-file-attachments branch from aa3828d to f091109 Compare March 11, 2024 15:05
@lmoesle lmoesle marked this pull request as ready for review March 11, 2024 15:34
@simonhir simonhir self-requested a review March 14, 2024 05:48
@lmoesle lmoesle force-pushed the feature/#1266-zammad-file-attachments branch from ba3d143 to 2f2c7f0 Compare March 14, 2024 09:48
@lmoesle lmoesle merged commit 7d22a2d into dev Mar 14, 2024
8 checks passed
@lmoesle lmoesle deleted the feature/#1266-zammad-file-attachments branch March 14, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zammad: Dateianhang
2 participants