Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1442 domain specific s3 in engine #1769

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

markostreich
Copy link
Contributor

@markostreich markostreich commented Jun 17, 2024

Description

  • Fixes wrong order of S3 configurations in the engine.
  • Removes redundant properties from the S3 integration service.

Reference

Issues: #1442

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change - See Dependency Graph
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@markostreich markostreich self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.47%. Comparing base (bbe03db) to head (c5951b4).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1769      +/-   ##
============================================
+ Coverage     44.51%   45.47%   +0.96%     
- Complexity     1707     1752      +45     
============================================
  Files           658      659       +1     
  Lines          9620     9795     +175     
  Branches        484      497      +13     
============================================
+ Hits           4282     4454     +172     
- Misses         5153     5155       +2     
- Partials        185      186       +1     
Flag Coverage Δ
unittests 45.47% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich requested a review from lehju June 17, 2024 08:06
@markostreich markostreich merged commit f9aa098 into dev Jun 17, 2024
15 of 16 checks passed
@markostreich markostreich deleted the fix/1442-domain-specific-s3-in-engine branch June 17, 2024 10:42
markostreich added a commit that referenced this pull request Jun 17, 2024
* 1442 fix usage of domain specific s3 in engine

* Revert "1442 fix usage of domain specific s3 in engine"

This reverts commit b3a504a.

* 1442 fix order of configurations

* 1442 remove redundant configuration

* 1442 remove redundant import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants