-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source maps do no respect sourceRoot #31
Comments
@Toxicable what is |
will happily take a patch for this 😄 |
@bcoe usually it's empty string by default. |
we need to also make sure that relative paths populated in To add an additional pain point, it seems that some sourceMap instrumenters sometimes add the filename in I think for a path forward:
|
@Toxicable mind checking if this is fixed in the latest release? I did some reworking around how we handled path resolution, in an effort to make it closer to Source Map V3. |
Whops, sorry for not checking back in here sooner. |
Under the build tool I am using .ts files do not live next to .js files, therefore we use sourceRoot to point the source maps at the correct source dir.
This line here: https://github.com/istanbuljs/v8-to-istanbul/blob/master/lib/v8-to-istanbul.js#L40
fails to resolve that logic, we've had to modify it to be
for it to be able to resolve sourceRoot's correctly
The text was updated successfully, but these errors were encountered: