Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logic for handling sourceRoot does not take into account process.cwd() #39

Merged
merged 1 commit into from
Jun 23, 2019
Merged

fix: logic for handling sourceRoot does not take into account process.cwd() #39

merged 1 commit into from
Jun 23, 2019

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jun 23, 2019

currently the logic for handling sourceRoot does not attempt to take into account process.cwd(), this means it can't work for relative paths in most environments.

@bcoe
Copy link
Member Author

bcoe commented Jun 23, 2019

CC: @Toxicable

@bcoe bcoe mentioned this pull request Jun 23, 2019
Closed
@bcoe bcoe merged commit 6ed9524 into master Jun 23, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 142

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 91.503%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/v8-to-istanbul.js 3 4 75.0%
Totals Coverage Status
Change from base Build 140: 0.04%
Covered Lines: 472
Relevant Lines: 513
💛 - Coveralls

@bcoe bcoe deleted the fix-relative branch June 23, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoe @coveralls