Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.46.0 #1533

Merged
merged 12 commits into from
Sep 28, 2023
Merged

0.46.0 #1533

merged 12 commits into from
Sep 28, 2023

Conversation

kishore03109
Copy link
Contributor

  • fix(announemnt): fix announcemnt bug #1532
  • Feat/text cards panel #1505
  • Fix/homepageAnnouncementScroll #1530
  • Feat/homepageAnnouncement #1502
  • fix(image): change image used #1531
  • chore(announcements): sync changes from template #1518
  • feat(feature tour): FF for hero #1508
  • refactor(hero): chnage to use breakpoints #1524
  • refactor(styles): shift to theme #1523
  • feat(announcements): add help overlay #1521
  • release(0.45.0): merge to develop #1519

seaerchin and others added 12 commits September 25, 2023 18:02
@seaerchin
Merge pull request #1519 from isomerpages/release/v0.45.0
7b046e1 
release(0.45.0): merge to develop
@dcshzj
feat(announcements): add help overlay (#1521)
2633742
@seaerchin
refactor(styles): shift to theme (#1523)
5be3e28 
Co-authored-by: seaerchin <[email protected]>
@seaerchin
refactor(hero): chnage to use breakpoints (#1524)
83cd575 
Co-authored-by: seaerchin <[email protected]>
@kishore03109
feat(feature tour): FF for hero (#1508)
fe243e9 
* fix(homepagepreview): add default if no variant

* build(inView): allows us to know if elem is in view

* chore(heroBannerToolTipImage): add in required image

* feat(hero feature tour): add in storybook for feature tour

* feat(hero): add in functionality within hero body

* fix(feature tour homepage): no need beacon

* fix(homepage preview): unintended rebase commit

* fix(feature tour): fix rebase issues

* fix(hero-body): fix bugs from rebase

* fix(feature tour): styling fixes)

* fix(feature tour): fix feature tour render when component is loading

* fix(feature tour): fix tip badge being shown

* fix(edithomepage): fix padding issue

* fix(featureTour): attempt ui bug w useEffect

* fix(hero body): add deps

---------

Co-authored-by: seaerchin <[email protected]>
@dcshzj
chore(announcements): sync changes from template (#1518)
a557904
@kishore03109
fix(image): change image used (#1531)
0489a26
@kishore03109
Feat/homepageAnnouncement (#1502)
c280afc 
* chore(images): add image for announcement modal

* feat(announcement): add new announcement

+ mutate shape to fit new biz req

* feat(announcements): mutate API

* feat(announcements): add storybooks

* fix(announcement): all users to see announcement

* chore(sites): rm redundant var

* feat(feature flag): add ff for announcemnt

* feat(announcement modal): more flexible API

* fix(styling): change colour

* fix(announcement): styling issues

* fix(announcement modal): fix spacing issue
@kishore03109
Fix/homepageAnnouncementScroll (#1530)
7282c6f 
* fix(announcement): add refs per announce item

* feat(announcement) use scroll ref

* fix(announce): attempt to fix open index issue

* fix(announce): revert buggy commit

This reverts commit b0fa396.

* fix(announcementBody): fix on scroll

* fix(deps): add import

* fix(announcemnet): workaround for bug

* fix(announcemnt): changed indezx

* fix(homepage preview): decalre type instead

* chore(Announcemnet body): add comment for clarity

* fix(announcemnet section): cleaner type

* chore(announcemnt section): rm redundant type
@alexanderleegs @harishv7
Feat/text cards panel (#1505)
1bec2ce 
* chore: add validators

* chore: add constants

* chore: add new textcard component types

* chore: add placeholder preview section

* chore: add new homepageDroppableZone type

* Feat: add textCards side panel

* feat: update useDrag to work with subtextcards

* feat: add text card parsing and change handler

* Fix: add button styles and restrict cards to 4

* fix: disable save on card error

* fix: rebase errors

* fix: remove comments

* fix: cast text cards once

* chore: remove unused updateElement

* fix: bug when attempting to create 2 textcard sections before adding text cards

Lodash behaviour here is buggy - _.set sets the fields in multiple array items for section data, which was causing errors

* chore: rename textcardcard

* feat: add help overlay and add feature flag (#1528)

* feat: add help overlay and add feature flag

* chore: rearrange resource position in add section

* IS-456: Text Cards Previews (#1516)

* wip: basic cms preview

* feat: refactor styles

Co-authored-by: Alexander Lee <[email protected]>

* feat: enable previews on text-cards

* fix: lint issues

* feat: update previews to match template

Co-authored-by: Alexander Lee <[email protected]>

---------

Co-authored-by: Alexander Lee <[email protected]>

* chore: refactor homepage to if/else to preserve existing behaviour (#1527)

* chore: refactor homepage to if/else to preserve existing behaviour

* fix: rebase errors

* fix: check for empty string

* fix: rename var

* fix: add type guards to create and delete and add comments

* chore: change to unknown

---------

Co-authored-by: Harish <[email protected]>
Co-authored-by: Alexander Lee <[email protected]>
@kishore03109
fix(announemnt): fix announcemnt bug (#1532)
200fda2
@kishore03109
0.46.0
f05e2e9
@kishore03109 kishore03109 mentioned this pull request Sep 27, 2023
Merged
@kishore03109 kishore03109 temporarily deployed to staging September 27, 2023 14:06 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 27, 2023 14:08 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 27, 2023 14:09 — with GitHub Actions Inactive
@kishore03109 kishore03109 temporarily deployed to staging September 27, 2023 14:09 — with GitHub Actions Inactive
@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited by dcshzj
Loading

Tests for #1532
https://github.com/isomerpages/isomercms-frontend/assets/42832651/7ba4eb3e-8ef3-4271-b990-1e9a8f1f2668

  • CRUD operations on announcemnts (eg like the video above)

@dcshzj

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited
Loading

Tests for #1505
https://github.com/isomerpages/isomercms-frontend/assets/22111124/2a1859ba-9350-4b5f-904a-663e8a504bd3

Tests

  • Go into edit homepage
  • Click on add new section -> text cards
  • New text card section should be editable
  • Errors should cause section to have error bar when minimized
  • Should be able to add a new card to this section
  • Should have a maximum of 4 cards in this section, after which add card button becomes disabled
  • Cards should be draggable
  • Errors in card section show up when card is minimized, and also when section is minimized
  • Errors should block saving
  • On save, changes should persist after refresh
    manually verified by @kishore03109

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited by dcshzj
Loading

Tests for #1530

Tests

  • When modifying announcements, the screen should scroll to the particular announcement that is being modified
    @dcshzj

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited by dcshzj
Loading

Tests for #1502
@dcshzj

Tests

  • Added in storybooks
  • login and you should see the new announcement (clear local storage / go incognito mode if you dont see it)

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited
Loading

Tests for #1518

@kishore03109 - > known bug, will be fixed in next release (@dcshzj let me know if I am mistaken here)

Tests

  • Navigate to any site with the announcements component
  • Ensure that there are no visible changes on the homepage preview
  • Ensure that on very small viewports (<= 425px), the announcements component title remains centred

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited by dcshzj
Loading

Tests for #1508
@dcshzj

  • Ensure that you are a whitelisted site
  • Login enter in to the /homepage site.
  • Ensure that when you expand the hero section, feature tour pops up

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited by dcshzj
Loading

Tests for #1524 + #1523
@dcshzj

Tests

  • go to homepage
  • add any component that requires padding etc from tailwind (used hero banner here)
  • the padding should exist

@kishore03109
Copy link
Contributor Author

kishore03109 commented Sep 28, 2023 •
edited
Loading

Tests for #1521
manually verified by @kishore03109

  • Visit any site that can create a new announcements block
  • Verify that the help overlay appears when hovering over the announcements block when adding a new section

@kishore03109 kishore03109 merged commit b7c204b into master Sep 28, 2023
24 of 25 checks passed
@mergify mergify bot deleted the release/0.46.0 branch September 28, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

@alexanderleegs alexanderleegs Awaiting requested review from alexanderleegs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kishore03109 @dcshzj @seaerchin @alexanderleegs