chore: refactor homepage to if/else to preserve existing behaviour #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderleegs
force-pushed
the
feat/text-cards-panel
branch
from
56dd050 to
34c3c8f
Compare
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
force-pushed
the
refactor/homepage-usedrag-to-if-else
branch
from
52b424f to
199f675
Compare
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
harishv7
reviewed
Sep 27, 2023
src/hooks/useDrag.tsx
Outdated
| if (typeof value === "string" && value.startsWith("textcardcard-")) { | ||
| const valArr = value.split("-") | ||
| const number = valArr[1] | ||
| return valArr.length === 2 && !Number.isNaN(Number(number)) |
There was a problem hiding this comment.
Nit: I think can just use isNaN directly without Number.isNaN?
There was a problem hiding this comment.
Is !Number.isNaN(Number(number)) to assert if its a number?
In the case where value is just textcardcard-, split gives ['textcardcard', '']
!Number.isNaN(Number(number)) evaluates to true here
There was a problem hiding this comment.
Eslint prefersNumber.isNaN because of the implicit coercion inside isNaN! I opted to use Number.isNan due to this
Good catch for the empty string, fixed in 4cf4b01
| const number = valArr[1] | ||
| return valArr.length === 2 && !Number.isNaN(Number(number)) | ||
| } | ||
| if (typeof value === "string") { |
There was a problem hiding this comment.
My linter is removing the else ifs here actually, since the if statement returns haha
| @@ -184,6 +184,31 @@ export const useDrag: OnDragEndResponseWrapper = ( | |||
| return updateHomepageState(result, homepageState) | |||
There was a problem hiding this comment.
this PR mainly changes the condiitonal logic from switch-case to if-else right? Why does switch-case not support
<subitem name>-<number>?
There was a problem hiding this comment.
^switch case not as powerful as match sadly enough :/
seaerchin
reviewed
Sep 27, 2023
src/hooks/useDrag.tsx
Outdated
| const isUpdateHomepageType = (value: any): value is UpdateHomepageType => { | ||
| if (typeof value === "string" && value.startsWith("textcardcard-")) { | ||
| const valArr = value.split("-") | ||
| const number = valArr[1] |
There was a problem hiding this comment.
nit: it might be confusing to see number = valArr[1] because the variable name number isn't describing its usage but rather its value.
could we use possibleCardIndex instead?
There was a problem hiding this comment.
Makes sense, e1e6969
alexanderleegs
force-pushed
the
refactor/homepage-usedrag-to-if-else
branch
from
199f675 to
96d0ddd
Compare
seaerchin
approved these changes
Sep 27, 2023
src/hooks/useDrag.tsx
Outdated
| | `textCardItem-${number}` | ||
|
|
||
| const isUpdateHomepageType = ( | ||
| value: any |
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
temporarily deployed
to
staging
GitHub Actions
Inactive
alexanderleegs
added a commit
that referenced
this pull request
Sep 27, 2023
…1527) * chore: refactor homepage to if/else to preserve existing behaviour * fix: rebase errors * fix: check for empty string * fix: rename var * fix: add type guards to create and delete and add comments * chore: change to unknown
alexanderleegs
added a commit
that referenced
this pull request
Sep 27, 2023
* chore: add validators * chore: add constants * chore: add new textcard component types * chore: add placeholder preview section * chore: add new homepageDroppableZone type * Feat: add textCards side panel * feat: update useDrag to work with subtextcards * feat: add text card parsing and change handler * Fix: add button styles and restrict cards to 4 * fix: disable save on card error * fix: rebase errors * fix: remove comments * fix: cast text cards once * chore: remove unused updateElement * fix: bug when attempting to create 2 textcard sections before adding text cards Lodash behaviour here is buggy - _.set sets the fields in multiple array items for section data, which was causing errors * chore: rename textcardcard * feat: add help overlay and add feature flag (#1528) * feat: add help overlay and add feature flag * chore: rearrange resource position in add section * IS-456: Text Cards Previews (#1516) * wip: basic cms preview * feat: refactor styles Co-authored-by: Alexander Lee <[email protected]> * feat: enable previews on text-cards * fix: lint issues * feat: update previews to match template Co-authored-by: Alexander Lee <[email protected]> --------- Co-authored-by: Alexander Lee <[email protected]> * chore: refactor homepage to if/else to preserve existing behaviour (#1527) * chore: refactor homepage to if/else to preserve existing behaviour * fix: rebase errors * fix: check for empty string * fix: rename var * fix: add type guards to create and delete and add comments * chore: change to unknown --------- Co-authored-by: Harish <[email protected]> Co-authored-by: Alexander Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces behaviour in
useDragfor homepage to allow for handling section subitems without changing the existing behaviour. This PR modifies theswitch/casestoif/elseinstead to allow for types of the form<subitem name>-<number>.