IS-456: Text Cards Previews #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishv7
requested review from
alexanderleegs,
seaerchin,
dcshzj and
kishore03109
and removed request for
alexanderleegs and
seaerchin
seaerchin
approved these changes
Sep 22, 2023
|
Note: Some comments from design, will merge after fixing it |
alexanderleegs
force-pushed
the
feat/text-cards-panel
branch
2 times, most recently
from
56dd050 to
34c3c8f
Compare
Co-authored-by: Alexander Lee <[email protected]>
Co-authored-by: Alexander Lee <[email protected]>
harishv7
force-pushed
the
IS-456-text-cards-previews
branch
from
2fed57b to
0031790
Compare
alexanderleegs
added a commit
that referenced
this pull request
Sep 27, 2023
* wip: basic cms preview * feat: refactor styles Co-authored-by: Alexander Lee <[email protected]> * feat: enable previews on text-cards * fix: lint issues * feat: update previews to match template Co-authored-by: Alexander Lee <[email protected]> --------- Co-authored-by: Alexander Lee <[email protected]>
alexanderleegs
added a commit
that referenced
this pull request
Sep 27, 2023
* chore: add validators * chore: add constants * chore: add new textcard component types * chore: add placeholder preview section * chore: add new homepageDroppableZone type * Feat: add textCards side panel * feat: update useDrag to work with subtextcards * feat: add text card parsing and change handler * Fix: add button styles and restrict cards to 4 * fix: disable save on card error * fix: rebase errors * fix: remove comments * fix: cast text cards once * chore: remove unused updateElement * fix: bug when attempting to create 2 textcard sections before adding text cards Lodash behaviour here is buggy - _.set sets the fields in multiple array items for section data, which was causing errors * chore: rename textcardcard * feat: add help overlay and add feature flag (#1528) * feat: add help overlay and add feature flag * chore: rearrange resource position in add section * IS-456: Text Cards Previews (#1516) * wip: basic cms preview * feat: refactor styles Co-authored-by: Alexander Lee <[email protected]> * feat: enable previews on text-cards * fix: lint issues * feat: update previews to match template Co-authored-by: Alexander Lee <[email protected]> --------- Co-authored-by: Alexander Lee <[email protected]> * chore: refactor homepage to if/else to preserve existing behaviour (#1527) * chore: refactor homepage to if/else to preserve existing behaviour * fix: rebase errors * fix: check for empty string * fix: rename var * fix: add type guards to create and delete and add comments * chore: change to unknown --------- Co-authored-by: Harish <[email protected]> Co-authored-by: Alexander Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adds previews for text cards on CMS
Closes IS-456
Solution
Followed suggested approach on template doc to enable text-card previews on CMS.
Breaking Changes
Tests
Unit tests (using
npm run tests)e2e tests (comment on this PR with the text
!run e2e)Smoke tests
You should be able to add text cards section
A max of 4 text cards should be allowed to be added